Changeset 1235

Show
Ignore:
Timestamp:
11/25/06 13:39:09
Author:
pvanhoof
Message:

API change

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/ChangeLog

    r1228 r1235  
    1818        * Major fixes and refactoring for the rfc822 support 
    1919        * Reimplemented TnyGtkMsgWindow 
    20         * Added a tny_msg_view_create_new_mytype API 
     20        * Added a tny_msg_view_create_new_inline_viewer API 
    2121 
    2222        * This was a major API change in libtinymailui & libtinymailui-gtk 

  • trunk/libtinymailui-gtk/tny-gtk-msg-view.c

    r1234 r1235  
    324324 
    325325static TnyMsgView* 
    326 tny_gtk_msg_view_create_new_mytype (TnyMsgView *self) 
    327 { 
    328         return TNY_GTK_MSG_VIEW_GET_CLASS (self)->create_new_mytype_func (self); 
     326tny_gtk_msg_view_create_new_inline_viewer (TnyMsgView *self) 
     327{ 
     328        return TNY_GTK_MSG_VIEW_GET_CLASS (self)->create_new_inline_viewer_func (self); 
    329329} 
    330330 
    331331static TnyMsgView* 
    332 tny_gtk_msg_view_create_new_mytype_default (TnyMsgView *self) 
     332tny_gtk_msg_view_create_new_inline_viewer_default (TnyMsgView *self) 
    333333{ 
    334334        return tny_gtk_msg_view_new (); 
    …… 
    386386        } else if (priv->display_rfc822 && tny_mime_part_content_type_is (part, "message/rfc822")) 
    387387        { 
    388                 retval = TNY_MIME_PART_VIEW (tny_msg_view_create_new_mytype (self)); 
     388                retval = TNY_MIME_PART_VIEW (tny_msg_view_create_new_inline_viewer (self)); 
    389389                gtk_scrolled_window_set_policy (GTK_SCROLLED_WINDOW (retval), 
    390390                                        GTK_POLICY_NEVER, GTK_POLICY_NEVER); 
    …… 
    853853        klass->clear_func = tny_gtk_msg_view_clear; 
    854854        klass->create_mime_part_view_for_func = tny_gtk_msg_view_create_mime_part_view_for; 
    855         klass->create_new_mytype_func = tny_gtk_msg_view_create_new_mytype; 
     855        klass->create_new_inline_viewer_func = tny_gtk_msg_view_create_new_inline_viewer; 
    856856 
    857857        return; 
    …… 
    889889        class->clear_func = tny_gtk_msg_view_clear_default; 
    890890        class->create_mime_part_view_for_func = tny_gtk_msg_view_create_mime_part_view_for_default; 
    891         class->create_new_mytype_func = tny_gtk_msg_view_create_new_mytype_default; 
     891        class->create_new_inline_viewer_func = tny_gtk_msg_view_create_new_inline_viewer_default; 
    892892 
    893893        g_type_class_add_private (object_class, sizeof (TnyGtkMsgViewPriv)); 

  • trunk/libtinymailui-gtk/tny-gtk-msg-view.h

    r1213 r1235  
    6060        void (*clear_func) (TnyMsgView *self); 
    6161        TnyMimePartView* (*create_mime_part_view_for_func) (TnyMsgView *self, TnyMimePart *part); 
    62         TnyMsgView* (*create_new_mytype_func) (TnyMsgView *self); 
     62        TnyMsgView* (*create_new_inline_viewer_func) (TnyMsgView *self); 
    6363 
    6464}; 

  • trunk/libtinymailui-gtk/tny-gtk-msg-window.c

    r1219 r1235  
    127127 
    128128static TnyMsgView*  
    129 tny_gtk_msg_window_create_new_mytype (TnyMsgView *self) 
    130 { 
    131         return TNY_GTK_MSG_WINDOW_GET_CLASS (self)->create_new_mytype_func (self); 
     129tny_gtk_msg_window_create_new_inline_viewer (TnyMsgView *self) 
     130{ 
     131        return TNY_GTK_MSG_WINDOW_GET_CLASS (self)->create_new_inline_viewer_func (self); 
    132132} 
    133133 
    134134static TnyMsgView*  
    135 tny_gtk_msg_window_create_new_mytype_default (TnyMsgView *self) 
     135tny_gtk_msg_window_create_new_inline_viewer_default (TnyMsgView *self) 
    136136{ 
    137137        TnyGtkMsgWindowPriv *priv = TNY_GTK_MSG_WINDOW_GET_PRIVATE (self); 
    …… 
    140140           embeddable within a window. So we even decorate this one as usual. */ 
    141141 
    142         return tny_msg_view_create_new_mytype (priv->msg_view); 
     142        return tny_msg_view_create_new_inline_viewer (priv->msg_view); 
    143143} 
    144144 
    …… 
    261261        klass->set_unavailable_func = tny_gtk_msg_window_set_unavailable; 
    262262        klass->clear_func = tny_gtk_msg_window_clear; 
     263        klass->create_mime_part_view_for_func = tny_gtk_msg_window_create_mime_part_view_for; 
     264        klass->create_new_inline_viewer_func = tny_gtk_msg_window_create_new_inline_viewer; 
    263265 
    264266        return; 
    …… 
    289291        class->set_unavailable_func = tny_gtk_msg_window_set_unavailable_default; 
    290292        class->clear_func = tny_gtk_msg_window_clear_default; 
    291         class->create_new_mytype_func = tny_gtk_msg_window_create_new_mytype_default; 
     293        class->create_new_inline_viewer_func = tny_gtk_msg_window_create_new_inline_viewer_default; 
    292294        class->create_mime_part_view_for_func = tny_gtk_msg_window_create_mime_part_view_for_default; 
    293  
    294295        class->get_part_func = tny_gtk_msg_window_mp_get_part_default; 
    295296        class->set_part_func = tny_gtk_msg_window_mp_set_part_default; 

  • trunk/libtinymailui-gtk/tny-gtk-msg-window.h

    r1213 r1235  
    5959        void (*clear_func) (TnyMsgView *self); 
    6060        TnyMimePartView* (*create_mime_part_view_for_func) (TnyMsgView *self, TnyMimePart *part); 
    61         TnyMsgView* (*create_new_mytype_func) (TnyMsgView *self); 
     61        TnyMsgView* (*create_new_inline_viewer_func) (TnyMsgView *self); 
    6262        TnyMimePart* (*get_part_func) (TnyMimePartView *self); 
    6363        void (*set_part_func) (TnyMimePartView *self, TnyMimePart *part); 

  • trunk/libtinymailui-mozembed/tny-moz-embed-msg-view.c

    r1219 r1235  
    119119 
    120120static TnyMsgView* 
    121 tny_moz_embed_msg_view_create_new_mytype (TnyMsgView *self) 
     121tny_moz_embed_msg_view_create_new_inline_viewer (TnyMsgView *self) 
    122122{ 
    123         return TNY_MOZ_EMBED_MSG_VIEW_GET_CLASS (self)->create_new_mytype_func (self); 
     123        return TNY_MOZ_EMBED_MSG_VIEW_GET_CLASS (self)->create_new_inline_viewer_func (self); 
    124124} 
    125125 
    126126/** 
    127  * tny_moz_embed_msg_view_create_new_mytype_default: 
     127 * tny_moz_embed_msg_view_create_new_inline_viewer_default: 
    128128 * @self: a #TnyMozEmbedMsgView instance 
    129129 * 
    …… 
    134134 **/ 
    135135static TnyMsgView* 
    136 tny_moz_embed_msg_view_create_new_mytype_default (TnyMsgView *self) 
     136tny_moz_embed_msg_view_create_new_inline_viewer_default (TnyMsgView *self) 
    137137{ 
    138138        return tny_moz_embed_msg_view_new (); 
    …… 
    149149 
    150150        class->create_mime_part_view_for_func = tny_moz_embed_msg_view_create_mime_part_view_for_default; 
    151         class->create_new_mytype_func = tny_moz_embed_msg_view_create_new_mytype_default; 
     151        class->create_new_inline_viewer_func = tny_moz_embed_msg_view_create_new_inline_viewer_default; 
    152152 
    153153        object_class->finalize = tny_moz_embed_msg_view_finalize; 
    154154 
    155155        TNY_GTK_MSG_VIEW_CLASS (class)->create_mime_part_view_for_func = tny_moz_embed_msg_view_create_mime_part_view_for; 
    156         TNY_GTK_MSG_VIEW_CLASS (class)->create_new_mytype_func = tny_moz_embed_msg_view_create_new_mytype; 
     156        TNY_GTK_MSG_VIEW_CLASS (class)->create_new_inline_viewer_func = tny_moz_embed_msg_view_create_new_inline_viewer; 
    157157 
    158158        return; 

  • trunk/libtinymailui-mozembed/tny-moz-embed-msg-view.h

    r1213 r1235  
    4949        /* virtual methods */ 
    5050        TnyMimePartView* (*create_mime_part_view_for_func) (TnyMsgView *self, TnyMimePart *part); 
    51         TnyMsgView* (*create_new_mytype_func) (TnyMsgView *self); 
     51        TnyMsgView* (*create_new_inline_viewer_func) (TnyMsgView *self); 
    5252}; 
    5353 

  • trunk/libtinymailui/tny-msg-view.c

    r1217 r1235  
    2323 
    2424/** 
    25  * tny_msg_view_create_new_mytype: 
    26  * @self: A #TnyMsgView instance 
    27  * 
    28  * Create a new instance of the same type as @self. The returned instance 
    29  * must be unreferenced after use. 
     25 * tny_msg_view_create_new_inline_viewer: 
     26 * @self: A #TnyMsgView instance 
     27 * 
     28 * Create a new #TnyMsgView that can be used to display an inline message.  
     29 * Usually it will return a new instance of the same type as @self. The 
     30 * returned instance must be unreferenced after use. 
    3031 * 
    3132 * Implementors: This method should create and return a new #TnyMsgView instance  
    32  * of the same type as @self. This method will be used when a #TnyMsgView needs 
    33  * to create a new instance of itself to display inlined messages (like what 
    34  * message/rfc822 mime parts are). For example the #TnyGtkMsgView implementation 
    35  * will use this method to create for itself a new #TnyMsgView instance that it 
    36  * can embed. 
     33 * usually of the same type as @self. This method will be used when a 
     34 * #TnyMsgView needs to create a #TnyMsgView instance for displaying inlined  
     35 * messages (like what message/rfc822 mime parts are). For example the  
     36 * #TnyGtkMsgView implementation will use this method to create for itself a  
     37 * new #TnyMsgView instance that it can embed in itself. 
    3738 * 
    3839 * Example: 
    3940 * <informalexample><programlisting> 
    4041 * static TnyMsgView* 
    41  * tny_my_html_msg_view_create_new_mytype (TnyMsgView *self) 
     42 * tny_my_html_msg_view_create_new_new_inline_viewer (TnyMsgView *self) 
    4243 * { 
    4344 *    return tny_my_html_msg_view_new (); 
    …… 
    5253 **/ 
    5354TnyMsgView*  
    54 tny_msg_view_create_new_mytype (TnyMsgView *self) 
    55 { 
    56 #ifdef DEBUG 
    57         if (!TNY_MSG_VIEW_GET_IFACE (self)->create_new_mytype_func) 
    58                 g_critical ("You must implement tny_msg_view_create_new_mytype\n"); 
    59 #endif 
    60  
    61         return TNY_MSG_VIEW_GET_IFACE (self)->create_new_mytype_func (self); 
     55tny_msg_view_create_new_inline_viewer (TnyMsgView *self) 
     56{ 
     57#ifdef DEBUG 
     58        if (!TNY_MSG_VIEW_GET_IFACE (self)->create_new_new_inline_viewer_func) 
     59                g_critical ("You must implement tny_msg_view_create_new_new_inline_viewer\n"); 
     60#endif 
     61 
     62        return TNY_MSG_VIEW_GET_IFACE (self)->create_new_inline_viewer_func (self); 
    6263} 
    6364 

  • trunk/libtinymailui/tny-msg-view.h

    r1213 r1235  
    4747        void (*clear_func) (TnyMsgView *self); 
    4848        TnyMimePartView* (*create_mime_part_view_for_func) (TnyMsgView *self, TnyMimePart *part); 
    49         TnyMsgView* (*create_new_mytype_func) (TnyMsgView *self); 
     49        TnyMsgView* (*create_new_inline_viewer_func) (TnyMsgView *self); 
    5050}; 
    5151 
    …… 
    5656void  tny_msg_view_set_unavailable (TnyMsgView *self); 
    5757TnyMimePartView* tny_msg_view_create_mime_part_view_for (TnyMsgView *self, TnyMimePart *part); 
    58 TnyMsgView* tny_msg_view_create_new_mytype (TnyMsgView *self); 
     58TnyMsgView* tny_msg_view_create_new_inline_viewer (TnyMsgView *self); 
    5959 
    6060G_END_DECLS