Changeset 1304
- Timestamp:
- 12/08/06 12:44:29
- Files:
-
- trunk/libtinymail-camel/tny-camel-account.c (modified) (1 diff)
- trunk/libtinymail-camel/tny-camel-store-account.c (modified) (2 diffs)
- trunk/libtinymail-camel/tny-camel-transport-account.c (modified) (5 diffs)
- trunk/libtinymail-camel/tny-session-camel.c (modified) (1 diff)
- trunk/libtinymail-gnome-desktop/tny-gnome-account-store.c (modified) (7 diffs)
- trunk/libtinymailui-gtk/tny-gtk-header-list-model.c (modified) (2 diffs)
- trunk/tinymail/tny-demoui-summary-view.c (modified) (2 diffs)
Legend:
- Unmodified
- Added
- Removed
- Modified
- Copied
- Moved
trunk/libtinymail-camel/tny-camel-account.c
r1271 r1304 90 90 priv->url_string = g_strdup (url_string); 91 91 92 TNY_CAMEL_ACCOUNT_GET_CLASS (self)->reconnect_func (TNY_CAMEL_ACCOUNT (self)); 92 if (G_UNLIKELY (!TNY_CAMEL_ACCOUNT_GET_CLASS (self)->reconnect_func)) 93 g_error ("This TnyAccount instance isn't a fully implemented type\n"); 94 95 TNY_CAMEL_ACCOUNT_GET_CLASS (self)->reconnect_func ((TnyCamelAccount*)self); 93 96 94 97 return; trunk/libtinymail-camel/tny-camel-store-account.c
r1292 r1304 126 126 camel_url_free (url); 127 127 128 /* TODO: lock ->service */ 128 129 priv->service = camel_session_get_service 129 130 ((CamelSession*) priv->session, priv->url_string, 130 131 priv->type, priv->ex); 131 132 133 /* TODO: lock ->service */ 132 134 if (priv->service == NULL) 133 135 report_error (priv); … … 137 139 /* un officially supported provider */ 138 140 141 /* TODO: lock ->service */ 139 142 priv->service = camel_session_get_service 140 143 ((CamelSession*) priv->session, priv->url_string, 141 144 priv->type, priv->ex); 142 145 146 /* TODO: lock ->service */ 143 147 if (priv->service == NULL) 144 148 report_error (priv); trunk/libtinymail-camel/tny-camel-transport-account.c
r1287 r1304 21 21 22 22 #include <glib.h> 23 #include <glib/gi18n-lib.h> 23 24 24 25 #include <string.h> … … 58 59 TnyCamelAccountPriv *priv = TNY_CAMEL_ACCOUNT_GET_PRIVATE (self); 59 60 61 printf ("recon\n"); 62 60 63 if (G_LIKELY (priv->session) && G_UNLIKELY (priv->proto) && G_UNLIKELY (priv->host)) 61 64 { … … 78 81 priv->url_string = urlstr->str; 79 82 83 /* TODO: lock ->service */ 84 priv->service = camel_session_get_service 85 ((CamelSession*) priv->session, priv->url_string, 86 priv->type, priv->ex); 87 /* TODO: check ex and handle it with a GError */ 88 if (camel_exception_is_set (priv->ex)) 89 g_error ("Can't get service for transport account (%s)\n", 90 camel_exception_get_description (priv->ex)); 91 92 if (!camel_service_connect (priv->service, priv->ex)) 93 { 94 g_warning (_("Not connected with %s: %s\n"), priv->url_string, 95 camel_exception_get_description (priv->ex)); 96 camel_exception_clear (priv->ex); 97 } 98 80 99 g_string_free (urlstr, FALSE); 100 } else if (priv->url_string) 101 { 102 103 /* TODO: lock ->service */ 104 /* TODO: check for old instance and clear it */ 105 106 priv->service = camel_session_get_service 107 ((CamelSession*) priv->session, priv->url_string, 108 priv->type, priv->ex); 109 110 if (camel_exception_is_set (priv->ex)) 111 g_error ("Can't get service for transport account (%s)\n", 112 camel_exception_get_description (priv->ex)); 113 /* TODO: check ex and handle it with a GError */ 114 115 if (!camel_service_connect (priv->service, priv->ex)) 116 { 117 g_warning (_("Not connected with %s: %s\n"), priv->url_string, 118 camel_exception_get_description (priv->ex)); 119 camel_exception_clear (priv->ex); 120 } 81 121 } 82 122 } … … 104 144 g_assert (CAMEL_IS_SESSION (apriv->session)); 105 145 106 transport = camel_session_get_transport ((CamelSession*) apriv->session, 146 /* TODO: lock ->service */ 147 if (!apriv->service) 148 { /* TODO do some more checking on ->service */ 149 g_critical ("No service, going to try getting a forced online one"); 150 transport = camel_session_get_transport ((CamelSession*) apriv->session, 107 151 apriv->url_string, &ex); 152 if (camel_exception_is_set (&ex)) 153 g_critical ("Didn't work (%s)", 154 camel_exception_get_description (&ex)); 155 apriv->service = (CamelService*) transport; 156 } else 157 { 158 if (!camel_service_connect (apriv->service, apriv->ex)) 159 { 160 g_warning (_("Not connected with %s: %s\n"), apriv->url_string, 161 camel_exception_get_description (apriv->ex)); 162 camel_exception_clear (apriv->ex); 163 } 164 } 108 165 109 166 if (camel_exception_is_set (&ex) || !transport) … … 181 238 TnyCamelAccountPriv *apriv = TNY_CAMEL_ACCOUNT_GET_PRIVATE (self); 182 239 240 apriv->service = NULL; 183 241 apriv->connected = FALSE; 184 242 apriv->type = CAMEL_PROVIDER_TRANSPORT; trunk/libtinymail-camel/tny-session-camel.c
r949 r1304 162 162 pf = copy->data; 163 163 164 if (G_UNLIKELY (pf->service == NULL) || G_UNLIKELY (pf->account == NULL)) 164 if (G_UNLIKELY (pf->service == NULL) || G_UNLIKELY (pf->account == NULL) || 165 !CAMEL_IS_SERVICE (pf->service) || !TNY_IS_ACCOUNT (pf->account)) 165 166 { 166 167 mark_del = g_list_prepend (mark_del, copy); trunk/libtinymail-gnome-desktop/tny-gnome-account-store.c
r1290 r1304 188 188 const gchar *accountid; 189 189 190 gdk_threads_enter ();191 192 190 accountid = tny_account_get_id (account); 193 191 … … 231 229 } 232 230 233 gdk_threads_leave ();234 235 231 return retval; 236 232 } 233 237 234 238 235 static void … … 258 255 259 256 #endif 260 261 257 262 258 static gboolean … … 281 277 } 282 278 283 gdk_threads_enter ();284 285 279 dialog = gtk_message_dialog_new (NULL, GTK_DIALOG_MODAL, 286 gtktype, GTK_BUTTONS_YES_NO, prompt);280 gtktype, GTK_BUTTONS_YES_NO, prompt); 287 281 288 282 if (gtk_dialog_run (GTK_DIALOG (dialog)) == GTK_RESPONSE_YES) … … 291 285 gtk_widget_destroy (dialog); 292 286 293 gdk_threads_leave ();294 295 287 return retval; 296 288 } 289 297 290 298 291 static void … … 391 384 account = TNY_ACCOUNT (tny_camel_transport_account_new ()); 392 385 } else if (type && (types == TNY_ACCOUNT_STORE_BOTH || types == TNY_ACCOUNT_STORE_STORE_ACCOUNTS)) 393 { 386 { 394 387 if (!g_ascii_strncasecmp (proto, "imap", 4)) 395 388 account = TNY_ACCOUNT (tny_camel_imap_store_account_new ()); … … 486 479 tny_account_set_pass_func (TNY_ACCOUNT (account), 487 480 per_account_get_pass_func); 488 481 489 482 tny_list_prepend (list, (GObject*)account); 490 483 g_object_unref (G_OBJECT (account)); trunk/libtinymailui-gtk/tny-gtk-header-list-model.c
r1302 r1304 264 264 265 265 readable_date_size = strftime (readable_date, 63, _("%Y-%m-%d, %-I:%M %p"), &file_time); 266 266 267 267 return readable_date; 268 268 } … … 697 697 GList *list; 698 698 GFunc relaxed_func, final_func; 699 gpointer ffdata, ffudata;699 gpointer ffdata, ffudata; 700 700 } RelaxedData; 701 701 trunk/tinymail/tny-demoui-summary-view.c
r1287 r1304 556 556 { 557 557 558 /* DEBUG 558 /* DEBUG */ 559 559 TnyAccountStore *astore = priv->account_store; 560 560 TnyList *accs = tny_simple_list_new (); … … 573 573 g_object_unref (G_OBJECT (iter)); 574 574 g_object_unref (G_OBJECT (accs)); 575 */ 575 576 576 577 577 msgwin = tny_gtk_msg_window_new (
