Changeset 1541

Timestamp:

02/02/07 16:36:51

Author:

pvanhoof

Message:

Changed a silly API

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-account.c (modified) (6 diffs)
• trunk/libtinymail-camel/tny-camel-account.h (modified) (2 diffs)
• trunk/libtinymail-camel/tny-camel-store-account.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-transport-account.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-session-camel.c (modified) (1 diff)
• trunk/tests/shared/account-store.c (modified) (2 diffs)

trunk/ChangeLog

@@ -4 +4 @@
-        provider of camel-lite. This means that the POP3 support now supports
-        offline viewing E-mails
+        * Changed a silly internal libtinymail-camel API
+
+        * This was a major API change in libtinymail-camel
-
-2007-01-31  Dirk-Jan C. Binnema <djcb@djcbsoftware.nl>

trunk/libtinymail-camel/tny-camel-account.c

@@ -701 +701 @@
-
-/**
-_status
+
- * @self: a #TnyCamelAccount object
-ffline: whether or not the account is off
+nline: whether or not the account is on
- * @err: a #GError instance or NULL
- *
@@ -710 +710 @@
- **/
-void 
-_status (TnyCamelAccount *self, gboolean off
-
-status_func (self, off
+ (TnyCamelAccount *self, gboolean on
+
+func (self, on
-}
-
-void 
-status_default (TnyCamelAccount *self, gboolean off
+default (TnyCamelAccount *self, gboolean on
-{
-        TnyCamelAccountPriv *priv = TNY_CAMEL_ACCOUNT_GET_PRIVATE (self);
@@ -737 +737 @@
-        }
-
-
-
+/* 
+ */
-
-        if (CAMEL_IS_DISCO_STORE (priv->service)) {
-!off
+on
-                        camel_disco_store_set_status (CAMEL_DISCO_STORE (priv->service),
-                                                                                  CAMEL_DISCO_STORE_ONLINE, &ex);
@@ -754 +754 @@
-        } else if (CAMEL_IS_OFFLINE_STORE (priv->service)) {
-                
-!off
+on
-                        
-                        camel_offline_store_set_network_state (CAMEL_OFFLINE_STORE (priv->service),
@@ -768 +768 @@
-        }
-
-off
+!on
-                camel_service_disconnect (CAMEL_SERVICE (priv->service),
-                                                                  TRUE, &ex);
@@ -913 +913 @@
-
-        class->add_option_func = tny_camel_account_add_option_default;
-status_func = tny_camel_account_set_online_status
+func = tny_camel_account_set_online
-
-        object_class->finalize = tny_camel_account_finalize;

trunk/libtinymail-camel/tny-camel-account.h

@@ -75 +75 @@
-
-        void (*add_option_func) (TnyCamelAccount *self, const gchar *option);
-status_func) (TnyCamelAccount *self, gboolean off
+func) (TnyCamelAccount *self, gboolean on
-
-        /* Abstract methods */
@@ -85 +85 @@
-void tny_camel_account_add_option (TnyCamelAccount *self, const gchar *option);
-void tny_camel_account_set_session (TnyCamelAccount *self, TnySessionCamel *session);
-_status (TnyCamelAccount *self, gboolean off
+ (TnyCamelAccount *self, gboolean on
-
-G_END_DECLS

trunk/libtinymail-camel/tny-camel-store-account.c

@@ -189 +189 @@
-                } else {
-                        apriv->connected = TRUE;
-_status (self, !
+ (self, 
-                }
-

trunk/libtinymail-camel/tny-camel-transport-account.c

@@ -198 +198 @@
-                } else {
-                        apriv->connected = TRUE;
-_status (self, !
+ (self, 
-                }
-

trunk/libtinymail-camel/tny-session-camel.c

@@ -410 +410 @@
-
-                if (err == NULL)
-_status (TNY_CAMEL_ACCOUNT (data), !
+ (TNY_CAMEL_ACCOUNT (data), 
-
-                if (err != NULL) 

trunk/tests/shared/account-store.c

@@ -112 +112 @@
-                tny_camel_account_set_session (TNY_CAMEL_ACCOUNT (account), me->session);
-                camel_session_set_online ((CamelSession*)me->session, me->force_online); 
-_status (TNY_CAMEL_ACCOUNT (account), !
+ (TNY_CAMEL_ACCOUNT (account), 
-
-                tny_account_set_proto (account, "imap");
@@ -132 +132 @@
-                tny_camel_account_set_session (TNY_CAMEL_ACCOUNT (account), me->session);
-                camel_session_set_online ((CamelSession*)me->session, me->force_online); 
-_status (TNY_CAMEL_ACCOUNT (account), !
+ (TNY_CAMEL_ACCOUNT (account), 
-
-                tny_account_set_proto (account, "something");