Changeset 1842

Show
Ignore:
Timestamp:
04/27/07 09:39:03
Author:
murrayc
Message:

2007-04-27 Murray Cumming <murrayc@murrayc.com>

        • libtinymail-maemo/tny-maemo-conic-device.c:

(on_connection_event), (tny_maemo_conic_device_get_iap): Added some comments and
improved the (temporary) debug output so its more obvious what is happening.

        • libtinymail/tny-device.c: Correct the tny_device_force_offline() and

tny_device_force_online() documentation. They were swapped.
This still needs more documentation describing how these behave.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/ChangeLog

    r1840 r1842  
     12007-04-27  Murray Cumming  <murrayc@murrayc.com> 
     2 
     3        * libtinymail-maemo/tny-maemo-conic-device.c: 
     4        (on_connection_event), (tny_maemo_conic_device_get_iap): Added some comments and  
     5        improved the (temporary) debug output so its more obvious what is happening. 
     6 
     7        * libtinymail/tny-device.c: Correct the tny_device_force_offline() and  
     8        tny_device_force_online() documentation. They were swapped. 
     9        This still needs more documentation describing how these behave. 
     10 
    1112007-04-26  Murray Cumming  <murrayc@murrayc.com> 
    212 

  • trunk/libtinymail-maemo/tny-maemo-conic-device.c

    r1840 r1842  
    5858 
    5959#ifdef MAEMO_CONIC_DUMMY 
    60         g_message ("outsmarting libconic"); 
     60        g_message ("%s: HACK: outsmarting libconic by emitting signal regardless of the reported connection status.", __FUNCTION__); 
    6161        g_signal_emit (device, tny_device_signals [TNY_DEVICE_CONNECTION_CHANGED], 
    6262                       0, TRUE); 
    …… 
    203203 * @iap_id: the id of the IAP to get 
    204204 *  
    205  * get the IAP object (#ConIcIap) for the give iap-id. The returned GObject must be 
     205 * get the IAP object (#ConIcIap) for the given iap-id. The returned GObject must be 
    206206 * freed with g_object_unref after use. Refer to the ConIc documentation for details about 
    207207 * the #ConICIap. 
    …… 
    221221        priv   = TNY_MAEMO_CONIC_DEVICE_GET_PRIVATE (self); 
    222222 
     223        /* Note that it is very unusual to return a reference from a get_() function,  
     224         * but we must do so because that mistake has already been made in  
     225         * con_ic_connection_get_iap(). 
     226         * If we just unref immediately then libconic might destroy the object. 
     227         */ 
    223228        return con_ic_connection_get_iap (priv->cnx, iap_id); 
    224229} 

  • trunk/libtinymail/tny-device.c

    r1724 r1842  
    4747 
    4848/** 
    49  * tny_device_force_offline: 
     49 * tny_device_force_online: 
    5050 * @self: a #TnyDevice object 
    5151 *  
    52  * Force offline status 
    53  *  
    54  * Example: 
    55  * <informalexample><programlisting> 
    56  * TnyDevice *device = ... 
    57  * tny_device_force_offline (device); 
    58  * if (tny_device_is_online (device)) 
    59  *      g_print ("Something is wrong\n"); 
    60  * tny_device_reset (device); 
    61  * </programlisting></informalexample> 
     52 * Force online status 
    6253 **/ 
    6354void  
    …… 
    7970 
    8071/** 
    81  * tny_device_force_online: 
     72 * tny_device_force_offline: 
    8273 * @self: a #TnyDevice object 
    8374 *  
    84  * Force online status 
     75 * Force offline status 
     76 *  
     77 * Example: 
     78 * <informalexample><programlisting> 
     79 * TnyDevice *device = ... 
     80 * tny_device_force_offline (device); 
     81 * if (tny_device_is_online (device)) 
     82 *      g_print ("Something is wrong\n"); 
     83 * tny_device_reset (device); 
     84 * </programlisting></informalexample> 
    8585 **/ 
    8686void