Changeset 2484

Show
Ignore:
Timestamp:
07/24/07 08:32:50
Author:
murrayc
Message:

2007-07-23 Murray Cumming <murrayc@murrayc.com>

        • libtinymail-camel/tny-camel-account.c: Improved the

documentation for tny_camel_account_set_online().

        • libtinymail/tny-merge-folder.c: (tny_merge_folder_get_id),

(tny_merge_folder_instance_init): Use
unknown_mergefolder instead of an empty string for the default ID,
because an empty string is not allowed by the get_func_id() DBC
contract, causing a crash at runtime when DBC is enabled in the build.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/ChangeLog

    r2483 r2484  
     12007-07-23  Murray Cumming  <murrayc@murrayc.com> 
     2 
     3        * libtinymail-camel/tny-camel-account.c: Improved the  
     4        documentation for tny_camel_account_set_online(). 
     5 
     6        * libtinymail/tny-merge-folder.c: (tny_merge_folder_get_id), 
     7        (tny_merge_folder_instance_init): Use  
     8        unknown_mergefolder instead of an empty string for the default ID,  
     9        because an empty string is not allowed by the get_func_id() DBC  
     10        contract, causing a crash at runtime when DBC is enabled in the build. 
     11 
    1122007-07-23  Jose Dapena Paz  <jdapena@igalia.com> 
    213 

  • trunk/libtinymail-camel/tny-camel-account.c

    r2470 r2484  
    11661166 * @err: a #GError instance or NULL 
    11671167 * 
    1168  * Set the connectivity status of an account 
     1168 * Set the connectivity status of an account. 
     1169 * Setting this to FALSE means that the account will not attempt to use the network,  
     1170 * and will use only the cache. 
     1171 * Setting this to TRUE means that the account may use the network to provide up-to-date  
     1172 * information. 
    11691173 * 
    11701174 **/ 

  • trunk/libtinymail/tny-merge-folder.c

    r2467 r2484  
    510510        } 
    511511 
     512        /* The get_id_func() DBC contract does not allow this to be NULL or "": */ 
     513        if ( (priv->id == NULL) || (strlen (priv->id) == 0)) { 
     514                priv->id = g_strdup ("unknown_mergefolder");     
     515        } 
     516         
    512517        return priv->id; 
    513518} 
    …… 
    12331238        TnyMergeFolderPriv *priv = TNY_MERGE_FOLDER_GET_PRIVATE (self); 
    12341239 
    1235         priv->id = g_strdup  (""); 
     1240        /* The get_id_func() DBC contract does not allow this to be NULL or "": */ 
     1241        priv->id = g_strdup ("unknown_mergefolder"); 
     1242         
    12361243        priv->mothers = tny_simple_list_new (); 
    12371244        priv->lock = g_new0 (GStaticRecMutex, 1);