Changeset 2641

Show
Ignore:
Timestamp:
08/15/07 14:08:26
Author:
murrayc
Message:

2007-08-15 Murray Cumming <murrayc@murrayc.com>

* libtinymail-maemo/tny-maemo-conic-device.c: (conic_emit_status):
Do not check for a running mainloop, because we know of no working
way to do this, and it causes hangs if we never use the idle handler.
See the comments in the code.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/ChangeLog

    r2639 r2641  
     12007-08-15  Murray Cumming  <murrayc@murrayc.com> 
     2 
     3        * libtinymail-maemo/tny-maemo-conic-device.c: (conic_emit_status): 
     4        Do not check for a running mainloop, because we know of no working  
     5        way to do this, and it causes hangs if we never use the idle handler. 
     6        See the comments in the code. 
     7 
    182007-08-15  Philip Van Hoof  <pvanhoof@gnome.org> 
    29 

  • trunk/libtinymail-maemo/tny-maemo-conic-device.c

    r2638 r2641  
    119119         * requires when there is no mainloop: 
    120120         */ 
    121         if (g_main_loop_is_running (NULL)) 
     121         /* TODO: We have no way to check for this now, and  
     122          * at this time it's not even clear whether tinymail should/can really  
     123          * demand this. murrayc. 15th Aug. 2007. 
     124          */ 
     125        if (TRUE) /* TODO: But NULL is not allowed here: g_main_loop_is_running (NULL)) */ 
    122126        { 
    123127                /* Emit it in an idle handler: */