Changeset 2941

Timestamp:

11/13/07 20:31:32

Author:

pvanhoof

Message:

• • • • Reference counting mistakes in TnyGtkFolderStoreTreeModel
        

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c (modified) (7 diffs)

trunk/ChangeLog

@@ -2 +2 @@
-
-        * Weak references for TnyHeader instances in TnyCamelMsgHeader
+        * Reference counting mistakes in TnyGtkFolderStoreTreeModel
-
-2007-11-12  Vivek Sekar  <viveksekar@gmail.com>

trunk/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c

@@ -129 +129 @@
-                        {
-                                found = TRUE;
+                                if (citem)
+                                        g_object_unref (citem);
-                                break;
-                        }
-                        if (citem)
-                                g_object_unref (citem);
-
-                        /* We search whether this folder that we have in the 
@@ -153 +153 @@
-                        g_object_unref (niter);
-
+                        if (citem)
+                                g_object_unref (citem);
+
-                  } while (gtk_tree_model_iter_next (mmodel, &miter));
-
@@ -211 +214 @@
-                                tny_folder_poke_status (TNY_FOLDER (folder));
-
-
+ {
-                                g_object_unref (mark_for_removal);
+                                mark_for_removal = NULL;
+                        }
-
-                } else {
@@ -219 +224 @@
-                                        tny_folder_get_id (TNY_FOLDER (mark_for_removal)));
-                                g_object_unref (mark_for_removal);
+                                mark_for_removal = NULL;
-                        }
-                }
@@ -271 +277 @@
-                        TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, 
-                        &citem, -1);
+
-                if (citem == (GObject *) fstore)
-                {
-                        name_iter = iter;
-                        found = TRUE;
+                        if (citem)
+                                g_object_unref (citem);
-                        break;
-                }
-
+
+
-
-          } while (gtk_tree_model_iter_next (model, &iter));
@@ -326 +336 @@
-          do 
-          {
-
+ = NULL
-
-                gtk_tree_model_get (model, &iter, 
-                        TNY_GTK_FOLDER_STORE_TREE_MODEL_INSTANCE_COLUMN, 
-                        &citem, -1);
+
-                if (citem == (GObject *) account)
-                {
-                        name_iter = iter;
-                        found = TRUE;
+                        if (citem)
+                                g_object_unref (citem);
-                        break;
-                }
-
+
+
+
-
-          } while (gtk_tree_model_iter_next (model, &iter));
@@ -702 +717 @@
-                        /* This removes a reference count */
-                        gtk_tree_store_remove (GTK_TREE_STORE (me), &iter);
-
+
+
-                        break;
-                }
-                if (citem)
-G_OBJECT (citem)
+citem
-
-          } while (gtk_tree_model_iter_next (model, &iter));