Changeset 3029

Timestamp:

11/28/07 23:37:52

Author:

pvanhoof

Message:

2007-11-28 Philip Van Hoof <pvanhoof@gnome.org>

• • • • Several fixes. in the bodystructure parsing
        
      • Several fixes in the mime part handling
        
      • Changed the API of mime part viewers to have a status
        

callback.

• • • • This was a major API change in libtinymail and libtinymailui
        

Files:

• devel/pvanhoof/bs/ChangeLog (modified) (1 diff)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-bs-mime-part.c (modified) (7 diffs)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-bs-mime-part.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-bs-msg-receive-strategy.c (modified) (1 diff)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-folder.c (modified) (7 diffs)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-mime-part.c (modified) (3 diffs)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-mime-part.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymail-camel/tny-camel-store-account.c (modified) (1 diff)
• devel/pvanhoof/bs/libtinymail/tny-mime-part.c (modified) (16 diffs)
• devel/pvanhoof/bs/libtinymail/tny-mime-part.h (modified) (2 diffs)
• devel/pvanhoof/bs/libtinymail/tny-shared.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-image-mime-part-view.c (modified) (7 diffs)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-image-mime-part-view.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-mime-part-save-strategy.c (modified) (10 diffs)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-mime-part-save-strategy.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-msg-view.c (modified) (4 diffs)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-msg-view.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-text-mime-part-view.c (modified) (6 diffs)
• devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-text-mime-part-view.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymailui-mozembed/tny-moz-embed-html-mime-part-view.c (modified) (6 diffs)
• devel/pvanhoof/bs/libtinymailui-mozembed/tny-moz-embed-html-mime-part-view.h (modified) (1 diff)
• devel/pvanhoof/bs/libtinymailui-mozembed/tny-moz-embed-msg-view.c (modified) (2 diffs)
• devel/pvanhoof/bs/libtinymailui/tny-mime-part-view.c (modified) (2 diffs)
• devel/pvanhoof/bs/tests/c-demo/tny-demoui-summary-view.c (modified) (3 diffs)

devel/pvanhoof/bs/ChangeLog

@@ +1 @@
+2007-11-28  Philip Van Hoof  <pvanhoof@gnome.org>
+
+        * Several fixes. in the bodystructure parsing
+        * Several fixes in the mime part handling
+        * Changed the API of mime part viewers to have a status
+        callback.
+
+        * This was a major API change in libtinymail and libtinymailui
+
-2007-11-27  Philip Van Hoof  <pvanhoof@gnome.org>
-

devel/pvanhoof/bs/libtinymail-camel/tny-camel-bs-mime-part.c

@@ -39 +39 @@
-#include <tny-stream-camel.h>
-#include <tny-camel-stream.h>
-
+
-#include <tny-fs-stream.h>
-
-static GObjectClass *parent_class = NULL;
-
-#include "tny-camel-bs-mime-part-priv.h"
-#include "tny-camel-bs-msg-priv.h"
-#include "tny-camel-bs-msg-header-priv.h"
-
-
@@ -60 +56 @@
-#include "camel/camel-stream-null.h"
-#include "camel/camel-mime-filter-charset.h"
+#include "camel/camel-folder.h"
+
+#include "tny-camel-queue-priv.h"
+#include "tny-camel-folder-priv.h"
+#include "tny-camel-account-priv.h"
+#include "tny-camel-store-account-priv.h"
+#include "tny-camel-bs-mime-part-priv.h"
+#include "tny-camel-bs-msg-priv.h"
+#include "tny-camel-bs-msg-header-priv.h"
+#include "tny-session-camel-priv.h"
+
+#define TINYMAIL_ENABLE_PRIVATE_API
+#include "tny-common-priv.h"
+#undef TINYMAIL_ENABLE_PRIVATE_API
+
+
-
-static ssize_t
@@ -163 +175 @@
-
-static void 
+decode_from_stream_to (TnyMimePart *self, TnyStream *from_stream, TnyStream *stream, gboolean binary, gboolean decode_text)
+{
+        TnyCamelBsMimePartPriv *priv = TNY_CAMEL_BS_MIME_PART_GET_PRIVATE (self);
+
+        if (decode_text && camel_strcase_equal (priv->bodystructure->content.type, "TEXT")) 
+        {
+                gchar *encoding = NULL;
+                gchar *charset = (gchar *) mimeparam_get_value_for (priv->bodystructure->content.params, "CHARSET");
+                CamelStream *cfrom_stream = tny_stream_camel_new (from_stream);
+                CamelStream *cto_stream = tny_stream_camel_new (stream);
+
+                if (!binary)
+                        encoding = priv->bodystructure->encoding;
+
+                if (!charset)
+                        charset = "UTF-8";
+
+                bs_camel_stream_format_text (cfrom_stream, cto_stream, charset, encoding);
+
+                camel_object_unref (cfrom_stream);
+                camel_object_unref (cto_stream);
+        } else {
+                if (binary)
+                        tny_stream_write_to_stream (from_stream, stream);
+                else {
+                        CamelStream *cfrom_stream = tny_stream_camel_new (from_stream);
+                        CamelStream *cto_stream = tny_stream_camel_new (stream);
+                        gchar *encoding = priv->bodystructure->encoding;
+
+                        decode_to_stream (cfrom_stream, cto_stream, encoding, FALSE);
+
+                        camel_object_unref (cfrom_stream);
+                        camel_object_unref (cto_stream);
+                }
+        }
+}
+
+static void 
-fetch_part (TnyMimePart *self, TnyStream *stream, gboolean decode_text)
-{
-        TnyCamelBsMimePartPriv *priv = TNY_CAMEL_BS_MIME_PART_GET_PRIVATE (self);
+        GError *err = NULL;
-
-        if (priv->folder) 
-        {
-                GError *err = NULL;
-                gboolean binary = TRUE;
-                TnyStream *from_stream;
-
-                /* binary = !camel_strcase_equal (priv->bodystructure->content.type, "TEXT"); */
-
-                from_stream = tny_camel_bs_msg_receive_strategy_start_receiving_part (
-                        priv->strat, priv->folder, TNY_CAMEL_BS_MIME_PART (self), &binary, &err);
@@ -181 +230 @@
-                        g_warning ("Error while fetching part: %s", err->message);
-                        g_error_free (err);
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
-
-                if (from_stream)
@@ -375 +391 @@
-}
-
+
+
+typedef struct {
+        TnyCamelQueueable parent;
+
+        GObject *self, *stream;
+        TnyMimePartCallback callback;
+        TnyStatusCallback status_callback;
+        gpointer user_data;
+        GError *err;
+        gboolean binary;
+        TnyStream *from_stream;
+        TnyIdleStopper *stopper;
+        TnySessionCamel *session;
+} DecodeAsyncInfo;
+
+
+static void
+decode_async_destroyer (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+        TnyCamelBsMimePartPriv *priv = TNY_CAMEL_BS_MIME_PART_GET_PRIVATE (info->self);
+        TnyCamelFolderPriv *fpriv = TNY_CAMEL_FOLDER_GET_PRIVATE (priv->folder);
+
+        _tny_camel_folder_unreason (fpriv);
+
+        g_object_unref (info->stream);
+        g_object_unref (info->self);
+        if (info->from_stream)
+                g_object_unref (info->from_stream);
+        if (info->err)
+                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
+
+        
+        return;
+}
+
+static gboolean
+decode_async_callback (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+
+        tny_lockable_lock (info->session->priv->ui_lock);
+
+        if (info->from_stream) {
+                decode_from_stream_to (TNY_MIME_PART (info->self), 
+                        TNY_STREAM (info->from_stream), TNY_STREAM (info->stream),
+                         info->binary, TRUE);
+        }
+
+        if (info->callback) { 
+                info->callback (TNY_MIME_PART (info->self), TNY_STREAM (info->stream), FALSE, info->err, info->user_data);
+        }
+
+        tny_lockable_unlock (info->session->priv->ui_lock);
+
+        return FALSE;
+}
+
+
+
+static void
+decode_async_cancelled_destroyer (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+        TnyCamelBsMimePartPriv *priv = TNY_CAMEL_BS_MIME_PART_GET_PRIVATE (info->self);
+        TnyCamelFolderPriv *fpriv = TNY_CAMEL_FOLDER_GET_PRIVATE (priv->folder);
+
+        _tny_camel_folder_unreason (fpriv);
+        g_object_unref (info->stream);
+        g_object_unref (info->self);
+        if (info->err)
+                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
+
+        
+        return;
+}
+
+
+static gboolean
+decode_async_cancelled_callback (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+        if (info->callback) { 
+                tny_lockable_lock (info->session->priv->ui_lock);
+                info->callback (TNY_MIME_PART (info->self), TNY_STREAM (info->stream), TRUE, info->err, info->user_data);
+                tny_lockable_unlock (info->session->priv->ui_lock);
+        }
+        return FALSE;
+}
+
+static void
+decode_async_status (struct _CamelOperation *op, const char *what, int sofar, int oftotal, void *user_data)
+{
+        DecodeAsyncInfo *oinfo = user_data;
+        TnyProgressInfo *info = NULL;
+
+        info = tny_progress_info_new (G_OBJECT (oinfo->self), oinfo->status_callback, 
+                TNY_FOLDER_STATUS, TNY_FOLDER_STATUS_CODE_GET_MSG, what, sofar, 
+                oftotal, oinfo->stopper, oinfo->session->priv->ui_lock, oinfo->user_data);
+
+        g_idle_add_full (G_PRIORITY_HIGH,
+                tny_progress_info_idle_func, info,
+                tny_progress_info_destroy);
+
+        return;
+}
+
+
+static gpointer 
+decode_async_thread (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+        TnyCamelBsMimePartPriv *priv = TNY_CAMEL_BS_MIME_PART_GET_PRIVATE (info->self);
+        TnyCamelFolderPriv *fpriv = TNY_CAMEL_FOLDER_GET_PRIVATE (priv->folder);
+
+        g_static_rec_mutex_lock (fpriv->folder_lock);
+
+        _tny_camel_account_start_camel_operation (TNY_CAMEL_ACCOUNT (fpriv->account), 
+                decode_async_status, info, "Getting part");
+
+        /* binary = !camel_strcase_equal (priv->bodystructure->content.type, "TEXT"); */
+        info->binary = TRUE;
+        info->from_stream = tny_camel_bs_msg_receive_strategy_start_receiving_part (
+                priv->strat, priv->folder, TNY_CAMEL_BS_MIME_PART (info->self), 
+                &info->binary, &info->err);
+
+        _tny_camel_account_stop_camel_operation (TNY_CAMEL_ACCOUNT (fpriv->account));
+
+        g_static_rec_mutex_unlock (fpriv->folder_lock);
+
+        return NULL;
+}
+
+
+static void
+tny_camel_bs_mime_part_decode_to_stream_async (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data)
+{
+        TNY_CAMEL_BS_MIME_PART_GET_CLASS (self)->decode_to_stream_async_func (self, stream, callback, status_callback, user_data);
+        return;
+}
+
+
+static void
+tny_camel_bs_mime_part_decode_to_stream_async_default (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data)
+{
+        DecodeAsyncInfo *info = g_slice_new0 (DecodeAsyncInfo);
+        TnyCamelBsMimePartPriv *priv = TNY_CAMEL_BS_MIME_PART_GET_PRIVATE (self);
+        TnyCamelFolderPriv *fpriv = TNY_CAMEL_FOLDER_GET_PRIVATE (priv->folder);
+
+        info->err = NULL;
+        info->session = TNY_FOLDER_PRIV_GET_SESSION (fpriv);
+        info->self = g_object_ref (self);
+        info->stream = g_object_ref (stream);
+        info->callback = callback;
+        info->status_callback = status_callback;
+        info->user_data = user_data;
+        info->stopper = tny_idle_stopper_new ();
+
+        _tny_camel_folder_reason (fpriv);
+
+        _tny_camel_queue_launch (TNY_FOLDER_PRIV_GET_QUEUE (fpriv), 
+                decode_async_thread, 
+                decode_async_callback,
+                decode_async_destroyer, 
+                decode_async_cancelled_callback,
+                decode_async_cancelled_destroyer, 
+                NULL,
+                info, sizeof (DecodeAsyncInfo), __FUNCTION__);
+
+        return;
+}
-
-
@@ -753 +947 @@
-        klass->get_header_pairs_func = tny_camel_bs_mime_part_get_header_pairs;
-        klass->set_header_pair_func = tny_camel_bs_mime_part_set_header_pair;
+        klass->decode_to_stream_async_func = tny_camel_bs_mime_part_decode_to_stream_async;
-
-        return;
@@ -789 +984 @@
-        class->get_header_pairs_func = tny_camel_bs_mime_part_get_header_pairs_default;
-        class->set_header_pair_func = tny_camel_bs_mime_part_set_header_pair_default;
+        class->decode_to_stream_async_func = tny_camel_bs_mime_part_decode_to_stream_async_default;
-
-        object_class->finalize = tny_camel_bs_mime_part_finalize;

devel/pvanhoof/bs/libtinymail-camel/tny-camel-bs-mime-part.h

@@ -71 +71 @@
-        void (*get_header_pairs_func) (TnyMimePart *self, TnyList *list);
-        void (*set_header_pair_func) (TnyMimePart *self, const gchar *name, const gchar *value);
+        void (*decode_to_stream_async_func) (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data);
-};
-

devel/pvanhoof/bs/libtinymail-camel/tny-camel-bs-msg-receive-strategy.c

@@ -89 +89 @@
-        } else {
-                int fd = open (filename, 0);
-
+
+
+
+
+
+
+
+
-        }
-

devel/pvanhoof/bs/libtinymail-camel/tny-camel-folder.c

@@ -907 +907 @@
-                g_error_free (info->err);
-
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
+
-        return;
-}
@@ -1520 +1523 @@
-        if (info->err)
-                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
-
-        return;
@@ -1727 +1733 @@
-        if (info->err)
-                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
+
-        return;
-}
@@ -1954 +1964 @@
-        g_object_unref (info->self);
-        g_object_unref (info->headers);
+
-        return;
-}
@@ -2242 +2253 @@
-        if (info->err)
-                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
-
-        return;
@@ -3272 +3286 @@
-        g_object_unref (info->into);
-
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
+
-        return;
-}
@@ -3856 +3873 @@
-        if (info->err)
-                g_error_free (info->err);
+
+        tny_idle_stopper_destroy (info->stopper);
+        info->stopper = NULL;
-
-        return;

devel/pvanhoof/bs/libtinymail-camel/tny-camel-mime-part.c

@@ -196 +196 @@
-}
-
+typedef struct {
+        GObject *self, *stream;
+        TnyMimePartCallback callback;
+        gpointer user_data;
+        GError *err;
+} DecodeAsyncInfo;
+
+
+static void
+decode_async_destroyer (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+        /* thread reference */
+        g_object_unref (info->self);
+        g_object_unref (info->stream);
+        if (info->err)
+                g_error_free (info->err);
+        g_slice_free (DecodeAsyncInfo, info);
+        return;
+}
+
+static gboolean
+decode_async_callback (gpointer user_data)
+{
+        DecodeAsyncInfo *info = (DecodeAsyncInfo *) user_data;
+        if (info->callback) { 
+                /* TODO: tny_lockable_lock (priv->ui_locker); */
+                info->callback (TNY_MIME_PART (info->self), TNY_STREAM (info->stream), 
+                        FALSE, info->err, info->user_data);
+                /* TODO: tny_lockable_unlock (priv->ui_locker); */
+        }
+        return FALSE;
+}
+
+/* This one is just to fulfil the API requirements */
+
+static void
+tny_camel_mime_part_decode_to_stream_async (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data)
+{
+        TNY_CAMEL_MIME_PART_GET_CLASS (self)->decode_to_stream_async_func (self, stream, callback, status_callback, user_data);
+        return;
+}
+
+static void
+tny_camel_mime_part_decode_to_stream_async_default (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data)
+{
+        DecodeAsyncInfo *info = g_slice_new0 (DecodeAsyncInfo);
+
+        tny_mime_part_decode_to_stream (self, stream);
+
+        info->self = g_object_ref (self);
+        info->stream = g_object_ref (stream);
+        info->callback = callback;
+        info->user_data = user_data;
+        info->err = NULL;
+
+        g_idle_add_full (G_PRIORITY_HIGH, 
+                                decode_async_callback, 
+                                info, decode_async_destroyer);
+
+        return;
+}
-
-
@@ -1008 +1070 @@
-        klass->get_header_pairs_func = tny_camel_mime_part_get_header_pairs;
-        klass->set_header_pair_func = tny_camel_mime_part_set_header_pair;
-
+
-        return;
-}
@@ -1044 +1106 @@
-        class->get_header_pairs_func = tny_camel_mime_part_get_header_pairs_default;
-        class->set_header_pair_func = tny_camel_mime_part_set_header_pair_default;
+        class->decode_to_stream_async_func = tny_camel_mime_part_decode_to_stream_async_default;
-
-        object_class->finalize = tny_camel_mime_part_finalize;

devel/pvanhoof/bs/libtinymail-camel/tny-camel-mime-part.h

@@ -73 +73 @@
-        void (*get_header_pairs_func) (TnyMimePart *self, TnyList *list);
-        void (*set_header_pair_func) (TnyMimePart *self, const gchar *name, const gchar *value);
+        void (*decode_to_stream_async_func) (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data);
+
-};
-

devel/pvanhoof/bs/libtinymail-camel/tny-camel-store-account.c

@@ -1297 +1297 @@
-        if (info->err)
-                g_error_free (info->err);
+
-        return;
-}

devel/pvanhoof/bs/libtinymail/tny-mime-part.c

@@ -38 +38 @@
- * 
- * Set a header pair (name: value) or delete a header (use NULL as value).
+ *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- *
- * Example:
@@ -148 +152 @@
- * Add a mime-part to @self.
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
+ *
- * Return value: The id of the added mime-part
- *
- **/
-gint
@@ -171 +178 @@
- * Delete a mime-part from @self
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- **/
-void
@@ -236 +246 @@
- * Set the content location of @self.
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- **/
-void
@@ -257 +270 @@
- * Set the description of @self.
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- **/
-void
@@ -278 +294 @@
- * Set the content id of @self.
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- **/
-void
@@ -298 +317 @@
- * Set the message as purged in cache
- *
+ * This is not a writing operation. Although it might change the content of a
+ * message for a user who's not connected with the server where @self originates
+ * from.
+ *
+ * Using the tny_msg_rewrite_cache API on a message instance will rewrite its 
+ * purged mime parts with an empty body (saving storage space). The storage 
+ * space is recovered after using tny_msg_rewrite_cache. Only setting a mime 
+ * part to purged might not remove it.
+ *
+ * There is no guarantee about what happens with a purged mime part internally 
+ * (it might get destroyed or become unuseful more early than the call to
+ * tny_msg_rewrite_cache).
- **/
-void
@@ -318 +349 @@
- * Set the filename of @self.
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- **/
-void
@@ -339 +373 @@
- * Set the content type of @self. Formatted as "type/subtype"
- *
+ * Note that not all TnyMimePart instances are writable. Only when creating
+ * a new message will the instance be guaranteed to be writable. This is a
+ * writing operation.
- **/
-void
@@ -362 +399 @@
- *
- * Return value: the filename of a mime part as a read-only string
- *
- **/
-const gchar*
@@ -390 +426 @@
- *
- * Return value: the content-id of a mime part as a read-only string
- *
- **/
-const gchar*
@@ -418 +453 @@
- *
- * Return value: a #gboolean
- *
- **/
-gboolean
@@ -469 +503 @@
- *
- * Return value: the content-location of a mime part as a read-only string
- *
- **/
-const gchar*
@@ -497 +530 @@
- * Efficiently write the content of @self to a stream. This will not read the 
- * data of the part in a memory buffer. In stead it will read the part data while
-
+
+
- *
- * You probably want to utilise the tny_mime_part_decode_to_stream
- * method in stead of this one. This method will not attempt to decode the
- * mime part. Mime parts are usually encoded in E-mails.
+ *
+ * When the mime part was received in BINARY mode from an IMAP server, then this
+ * API has mostly the same effect as the tny_mime_part_decode_to_stream: You 
+ * will get a non-encoded version of the data. A small difference will be that
+ * the tny_mime_part_decode_to_stream will decode certain special characters in
+ * TEXT/* mime parts (character set encoding) to UTF-8.
+ *
+ * However. A larger difference happens with binary mime parts that where not
+ * retrieved using BINARY. For those this API will give you the encoded data
+ * as is. This means that you will get a stream spitting out for example BASE64
+ * data.
- * 
- * Example:
@@ -537 +582 @@
- * Efficiently decode @self to a stream. This will not read the data of the
- * part in a memory buffer. In stead it will read the part data while already
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
- *
- * Example:
@@ -565 +626 @@
-        return;
-}
+
+/**
+ * tny_mime_part_decode_to_stream_async:
+ * @self: a #TnyMimePart object
+ * @stream: a #TnyMsgStream stream
+ * @callback: a #TnyMimePartCallback callback
+ * @status_callback: a #TnyStatusCallback callback
+ * @user_data: user data for @callback
+ *
+ * This method does the same as tny_mime_part_decode_to_stream. It just does 
+ * everything asynchronous and calls you back when finished.
+ */
+void
+tny_mime_part_decode_to_stream_async (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data)
+{
+#ifdef DBC /* require */
+        g_assert (TNY_IS_MIME_PART (self));
+        g_assert (stream);
+        g_assert (TNY_IS_STREAM (stream));
+        g_assert (TNY_MIME_PART_GET_IFACE (self)->decode_to_stream_async_func != NULL);
+#endif
+
+        TNY_MIME_PART_GET_IFACE (self)->decode_to_stream_async_func (self, stream, callback, status_callback, user_data);
+        return;
+}
+
+
-/**
- * tny_mime_part_construct_from_stream:

devel/pvanhoof/bs/libtinymail/tny-mime-part.h

@@ -68 +68 @@
-        void (*get_header_pairs_func) (TnyMimePart *self, TnyList *list);
-        void (*set_header_pair_func) (TnyMimePart *self, const gchar *name, const gchar *value);
+        void (*decode_to_stream_async_func) (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data);
-};
-
@@ -95 +96 @@
-void tny_mime_part_get_header_pairs (TnyMimePart *self, TnyList *list);
-void tny_mime_part_set_header_pair (TnyMimePart *self, const gchar *name, const gchar *value);
+void tny_mime_part_decode_to_stream_async (TnyMimePart *self, TnyStream *stream, TnyMimePartCallback callback, TnyStatusCallback status_callback, gpointer user_data);
-
-G_END_DECLS

devel/pvanhoof/bs/libtinymail/tny-shared.h

@@ -99 +99 @@
-typedef void (*TnyForgetPassFunc) (TnyAccount *self);
-typedef void (*TnyFolderCallback) (TnyFolder *self, gboolean canceled, GError *err, gpointer user_data);
+typedef void (*TnyMimePartCallback) (TnyMimePart *self, TnyStream *stream, gboolean canceled, GError *err, gpointer user_data);
-typedef void (*TnyGetHeadersCallback) (TnyFolder *self, gboolean canceled, TnyList *headers, GError *err, gpointer user_data);
-typedef void (*TnyGetMsgCallback) (TnyFolder *folder, gboolean canceled, TnyMsg *msg, GError *err, gpointer user_data);

devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-image-mime-part-view.c

@@ -51 +51 @@
-{
-        TnyMimePart *part;
+        TnyStatusCallback status_callback;
+        gpointer status_user_data;
-};
-
@@ -78 +80 @@
-
-static void 
+on_mime_part_decoded (TnyMimePart *part, TnyStream *dest, gboolean canceled, GError *err, gpointer user_data)
+{
+        TnyMimePartView *self = (TnyMimePartView *) user_data;
+        GdkPixbuf *pixbuf;
+        tny_stream_reset (dest);
+        pixbuf = tny_gtk_pixbuf_stream_get_pixbuf (TNY_GTK_PIXBUF_STREAM (dest));
+        gtk_image_set_from_pixbuf (GTK_IMAGE (self), pixbuf);
+        g_object_unref (self);
+}
+
+static void 
+on_status (GObject *part, TnyStatus *status, gpointer user_data)
+{
+        TnyMimePartView *self = (TnyMimePartView *) user_data;
+        TnyGtkImageMimePartViewPriv *priv = TNY_GTK_IMAGE_MIME_PART_VIEW_GET_PRIVATE (self);
+        if (priv->status_callback)
+                priv->status_callback (self, status, priv->status_user_data);
+        return;
+}
+
+static void 
-tny_gtk_image_mime_part_view_set_part_default (TnyMimePartView *self, TnyMimePart *part)
-{
@@ -84 +107 @@
-        g_assert (TNY_IS_MIME_PART (part));
-
-G_LIKELY (priv->part)
+priv->part
-                g_object_unref (priv->part);
-
-
-
-
-
-
-
-
+
+
-                tny_stream_reset (dest);
-
-
-
-
-
-
+
+
-                g_object_unref (dest);
-
-                priv->part = g_object_ref (part);
-        }
@@ -124 +137 @@
-/**
- * tny_gtk_image_mime_part_view_new:
+ * @status_callback: a #TnyStatusCallback for when status information happens
+ * @status_user_data: user data for @status_callback
- *
- * Create a new #TnyMimePartView for Gtk+
@@ -130 +145 @@
- **/
-TnyMimePartView*
-void
+TnyStatusCallback status_callback, gpointer status_user_data
-{
-        TnyGtkImageMimePartView *self = g_object_new (TNY_TYPE_GTK_IMAGE_MIME_PART_VIEW, NULL);
+        TnyGtkImageMimePartViewPriv *priv = TNY_GTK_IMAGE_MIME_PART_VIEW_GET_PRIVATE (self);
+
+        priv->status_callback = status_callback;
+        priv->status_user_data = status_user_data;
-
-        return TNY_MIME_PART_VIEW (self);
@@ -143 +162 @@
-        TnyGtkImageMimePartViewPriv *priv = TNY_GTK_IMAGE_MIME_PART_VIEW_GET_PRIVATE (self);
-
+        priv->status_callback = NULL;
+        priv->status_user_data = NULL;
-
-        return;
@@ -153 +174 @@
-        TnyGtkImageMimePartViewPriv *priv = TNY_GTK_IMAGE_MIME_PART_VIEW_GET_PRIVATE (self);
-
-G_LIKELY (priv->part)
-G_OBJECT (priv->part)
+priv->part
+priv->part
-
-        (*parent_class->finalize) (object);

devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-image-mime-part-view.h

@@ -59 +59 @@
-
-GType tny_gtk_image_mime_part_view_get_type (void);
-void
+TnyStatusCallback status_callback, gpointer status_user_data
-
-G_END_DECLS

devel/pvanhoof/bs/libtinymailui-gtk/tny-gtk-mime-part-save-strategy.c

@@ -47 +47 @@
-static GObjectClass *parent_class = NULL;
-
+typedef struct _TnyGtkMimePartSaveStrategyPriv TnyGtkMimePartSaveStrategyPriv;
+
+struct _TnyGtkMimePartSaveStrategyPriv
+{
+        TnyStatusCallback status_callback;
+        gpointer status_user_data;
+};
+
-#define TNY_GTK_MIME_PART_SAVE_STRATEGY_GET_PRIVATE(o) \
-        (G_TYPE_INSTANCE_GET_PRIVATE ((o), TNY_TYPE_GTK_MIME_PART_SAVE_STRATEGY, TnyGtkMimePartSaveStrategy