Changeset 3104

Timestamp:

12/12/07 20:39:13

Author:

jdapena

Message:

* libtinymail-camel/tny-camel-folder.c: load camel folder before

getting the url string of it.
* libtinymail-camel/tny-camel-msg-header.c: now the decorated header
can be added with g_object_ref or a weak reference.
* libtinymail-camel/tny-camel-folder.c: now the TnyCamelHeader? we
use to retrieve the message in find_msg is constructed from summary.
This is created in a way it's persistent, and then, we can access
properly to the summary flags. We also eturn null and set error if
message is not in summary.
* libtinymail-camel/tny-camel-full-msg-receive-strategy.c
libtinymail-camel/tny-camel-partial-msg-receive-strategy.c:
use the new TnyCamelMsgHeader? decorator api.
* Fixed minor build issues

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-folder.c (modified) (5 diffs)
• trunk/libtinymail-camel/tny-camel-full-msg-receive-strategy.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-msg-header-priv.h (modified) (2 diffs)
• trunk/libtinymail-camel/tny-camel-msg-header.c (modified) (4 diffs)
• trunk/libtinymail-camel/tny-camel-partial-msg-receive-strategy.c (modified) (1 diff)
• trunk/libtinymail/tny-merge-folder.c (modified) (3 diffs)

trunk/ChangeLog

@@ +1 @@
+2007-12-12  Jose Dapena Paz  <jdapena@igalia.com>
+
+        * libtinymail-camel/tny-camel-folder.c: load camel folder before
+        getting the url string of it.
+        * libtinymail-camel/tny-camel-msg-header.c: now the decorated header
+        can be added with g_object_ref or a weak reference.
+        * libtinymail-camel/tny-camel-folder.c: now the TnyCamelHeader we
+        use to retrieve the message in find_msg is constructed from summary. 
+        This is created in a way it's persistent, and then, we can access
+        properly to the summary flags. We also eturn null and set error if
+        message is not in summary.
+        * libtinymail-camel/tny-camel-full-msg-receive-strategy.c
+        libtinymail-camel/tny-camel-partial-msg-receive-strategy.c:
+        use the new TnyCamelMsgHeader decorator api.
+        * Fixed minor build issues.
+
-2007-12-12  Philip Van Hoof <pvanhoof@gnome.org>
-

trunk/libtinymail-camel/tny-camel-folder.c

@@ -177 +177 @@
-        TnyCamelFolderPriv *priv = TNY_CAMEL_FOLDER_GET_PRIVATE (self);
-        TnyCamelAccountPriv *apriv = TNY_CAMEL_ACCOUNT_GET_PRIVATE (priv->account);
-        TnyIterator *iter;
-        GList *list, *list_iter;
-
@@ -210 +209 @@
-        notify_folder_observers_about (TNY_FOLDER (info->self), 
-                TNY_FOLDER_CHANGE (info->change));
+
-        return FALSE;
-}
@@ -2466 +2466 @@
-        if (uid && uid[0] != '/' && strlen (uid) > 0)
-        {
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
-
-        } else {
@@ -4417 +4427 @@
-        TnyFolderStoreChange *change;
-        CamelException subex = CAMEL_EXCEPTION_INITIALISER;
-        TnyCamelFolderPriv *rpriv = NULL;
-        gboolean was_new = FALSE;
-
@@ -5292 +5301 @@
-                {
-                        char *urls = camel_service_get_url (apriv->service);
+                        if (!priv->folder)
+                                load_folder_no_lock (priv);
-                        const char *foln = camel_folder_get_full_name (priv->folder);
-                        retval = g_strdup_printf ("%s/%s", urls, foln);

trunk/libtinymail-camel/tny-camel-full-msg-receive-strategy.c

@@ -93 +93 @@
-                        nheader = _tny_camel_msg_header_new (CAMEL_MIME_MESSAGE (camel_message), 
-                                folder, tny_header_get_date_received (header));
-
+, FALSE
-
-                        message = tny_camel_msg_new ();

trunk/libtinymail-camel/tny-camel-msg-header-priv.h

@@ -55 +55 @@
-        gboolean partial;
-        TnyHeader *decorated;
+        gboolean decorated_has_ref;
-};
-
@@ -65 +66 @@
-TnyHeader* _tny_camel_msg_header_new (CamelMimeMessage *msg, TnyFolder *folder, time_t received);
-
-
+, gboolean add_reference
-
-G_END_DECLS

trunk/libtinymail-camel/tny-camel-msg-header.c

@@ -465 +465 @@
-        TnyCamelMsgHeader *me = (TnyCamelMsgHeader *) user_data;
-        me->decorated = NULL;
+        me->decorated_has_ref = FALSE;
-}
-
@@ -489 +490 @@
-
-        if (me->decorated) {
-
+
+
+
+
-                me->decorated = NULL;
-        }
@@ -528 +532 @@
-        self->partial = FALSE;
-        self->decorated = NULL;
+        self->decorated_has_ref = FALSE;
-        self->to = NULL;
-        self->from = NULL;
@@ -541 +546 @@
-void 
-_tny_camel_msg_header_set_decorated (TnyCamelMsgHeader *header, 
-
+
+
-{
-        g_assert (TNY_IS_HEADER (decorated));
-        if (header->decorated) {
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-
-        header->decorated = decorated;

trunk/libtinymail-camel/tny-camel-partial-msg-receive-strategy.c

@@ -94 +94 @@
-                        nheader = _tny_camel_msg_header_new (CAMEL_MIME_MESSAGE (camel_message), folder,
-                                tny_header_get_date_received (header));
-
+, FALSE
-                        message = tny_camel_msg_new ();
-                        _tny_camel_msg_set_received (TNY_CAMEL_MSG (message), 

trunk/libtinymail/tny-merge-folder.c

@@ -52 +52 @@
-{
-        TnyMergeFolderPriv *priv = TNY_MERGE_FOLDER_GET_PRIVATE (self);
-        TnyIterator *iter;
-        GList *list, *list_iter;
-
@@ -1016 +1015 @@
-tny_merge_folder_transfer_msgs (TnyFolder *self, TnyList *header_list, TnyFolder *folder_dst, gboolean delete_originals, GError **err)
-{
-        TnyMergeFolderPriv *priv = TNY_MERGE_FOLDER_GET_PRIVATE (self);
-        TnyIterator *iter;
-
@@ -1101 +1099 @@
-{
-        TransferMsgsInfo *info = thr_user_data;
-        TnyFolder *self = info->self;
-        TnyMergeFolderPriv *priv = TNY_MERGE_FOLDER_GET_PRIVATE (self);
-
-        tny_merge_folder_transfer_msgs (info->self, info->header_list, info->folder_dst, info->delete_originals, &info->err);