Changeset 3258

Timestamp:

01/14/08 23:21:50

Author:

pvanhoof

Message:

Memleak fixes and a bugfix

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymail-camel/camel-lite/camel/camel-folder-summary.h (modified) (1 diff)
• trunk/libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c (modified) (2 diffs)
• trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-local-summary.c (modified) (2 diffs)
• trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-maildir-summary.c (modified) (3 diffs)
• trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-mbox-summary.c (modified) (3 diffs)
• trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-mh-summary.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-folder.c (modified) (2 diffs)
• trunk/libtinymail/tny-folder-store-query.c (modified) (1 diff)

trunk/ChangeLog

@@ -7 +7 @@
-        CamelOperation holds one more significant memory leak at its
-        status_hack linked list. That one is not yet fixed.
+        * Flag setting to 0xffff must be 0x1fff as bit 13 and 14 are system
+        bits that should not be altered like that.
-
-2008-01-13  Philip Van Hoof <pvanhoof@gnome.org>

trunk/libtinymail-camel/camel-lite/camel/camel-folder-summary.h

@@ -90 +90 @@
-
-/* Changes to system flags will NOT trigger a folder changed event */
-f
+1
-
-typedef struct _CamelFlag {

trunk/libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c

@@ -442 +442 @@
-        CamelImapStore *imap_store = CAMEL_IMAP_STORE (object);
-
+        imap_store->authtypes = NULL;
-        imap_store->got_online = FALSE;
-        imap_store->going_online = FALSE;
@@ -785 +786 @@
-        /* We assume we have utf8 capable search until a failed search tells us otherwise */
-        store->capabilities = IMAP_CAPABILITY_utf8_search;
+
+        if (store->authtypes) {
+                g_hash_table_foreach_remove (store->authtypes,
+                                             free_key, NULL);
+                g_hash_table_destroy (store->authtypes);
+                store->authtypes = NULL;
+        }
+
-        store->authtypes = g_hash_table_new (g_str_hash, g_str_equal);
-        response = camel_imap_command (store, NULL, ex, "CAPABILITY");

trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-local-summary.c

@@ -458 +458 @@
-#endif
-                        mi->info.flags = camel_message_info_flags(info);
-f
+1
-                        mi->info.size = ((CamelMessageInfoBase*)info)->size;
-                }
@@ -506 +506 @@
-                p++;
-        if (*p == 0 && sscanf (uidstr, "%u", &uid) == 1) {
-f
+1
-        } else {
-f
+1
-        }
-

trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-maildir-summary.c

@@ -317 +317 @@
-#endif
-                        mi->info.flags = camel_message_info_flags(info);
-f
+1
-                        mi->info.size = ((CamelMessageInfoBase*)info)->size;
-                }
@@ -808 +808 @@
-
-                        /* have our flags/ i.e. name changed? */
-
+newname && 
-                                name = g_strdup_printf("%s/cur/%s", cls->folder_path, camel_maildir_info_filename(mdi));
-                                dest = g_strdup_printf("%s/cur/%s", cls->folder_path, newname);
@@ -815 +815 @@
-                                        /* we'll assume it didn't work, but dont change anything else */
-                                        g_free(newname);
+                                        newname = NULL;
-                                }
-                                g_free(name);
-                                g_free(dest);
-
+
+
+
-                                g_free(newname);
-                        }
-
-                        /* strip FOLDER_MESSAGE_FLAGED, etc */
-f
+1
-                }
-                camel_message_info_free(info);

trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-mbox-summary.c

@@ -234 +234 @@
-
-        if (*p == 0 && sscanf(uidstr, "%u", &uid) == 1) {
-f
+1
-        } else {
-f
+1
-        }
-}
@@ -814 +814 @@
-                camel_mime_parser_drop_step(mp);
-
-f
+1
-                camel_message_info_free((CamelMessageInfo *)info);
-        }
@@ -1032 +1032 @@
-                                goto error;
-                        }
-f
+1
-                        g_free(xevnew);
-                        xevnew = NULL;

trunk/libtinymail-camel/camel-lite/camel/providers/local/camel-mh-summary.c

@@ -337 +337 @@
-                        g_free(name);
-                } else if (info->info.flags & (CAMEL_MESSAGE_FOLDER_NOXEV|CAMEL_MESSAGE_FOLDER_FLAGGED)) {
-f
+1
-                }
-                camel_message_info_free(info);

trunk/libtinymail-camel/tny-camel-folder.c

@@ -2907 +2907 @@
-        {
-                TnyFolder *cur = TNY_FOLDER (tny_iterator_get_current (iter));
-
+list = 
-                g_object_unref (cur);
-                tny_iterator_next (iter);
@@ -4603 +4603 @@
-
-        if (!info || camel_exception_is_set (&ex) || !priv->account) {
-
+ {
-                        g_set_error (err, TNY_FOLDER_STORE_ERROR, 
-                                TNY_FOLDER_STORE_ERROR_CREATE_FOLDER,
-                                camel_exception_get_description (&ex));
-
+
+
-                        g_set_error (err, TNY_FOLDER_STORE_ERROR, 
-                                TNY_FOLDER_STORE_ERROR_CREATE_FOLDER,

trunk/libtinymail/tny-folder-store-query.c

@@ -76 +76 @@
-{
-        TnyFolderStoreQuery *self = (TnyFolderStoreQuery*) object;
-G_OBJECT (self->items)
+self->items
-        parent_class->finalize (object);
-        return;