Changeset 3385

Timestamp:

02/09/08 12:20:34

Author:

pvanhoof

Message:

2008-02-09 Philip Van Hoof <pvanhoof@gnome.org>

• • • • Crash when the IMAP server doesn't support namespaces
        
      • GLib Signal leakage in TnyGtkFolderStoreTreeModel
        
      • Various smaller fixes and code improvements
        

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymail-camel/bs/bodystruct.c (modified) (1 diff)
• trunk/libtinymail-camel/camel-lite/camel/camel-provider.c (modified) (1 diff)
• trunk/libtinymail-camel/camel-lite/summary/summary.c (modified) (1 diff)
• trunk/libtinymail-maemo/tny-maemo-account-store.c (modified) (1 diff)
• trunk/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c (modified) (5 diffs)

trunk/ChangeLog

@@ +1 @@
+2008-02-09  Philip Van Hoof <pvanhoof@gnome.org>
+
+        * Crash when the IMAP server doesn't support namespaces
+        * GLib Signal leakage in TnyGtkFolderStoreTreeModel
+        * Various smaller fixes and code improvements
+
-2008-02-05  Philip Van Hoof <pvanhoof@gnome.org>
-

trunk/libtinymail-camel/bs/bodystruct.c

@@ -193 +193 @@
-                                inptr++; /* My '(' */
-
- {
+
-                                        g_string_append (str, ", ");
-
-
+
-
-                                name = decode_qstring (&inptr, inend, err);

trunk/libtinymail-camel/camel-lite/camel/camel-provider.c

@@ -140 +140 @@
-
-                p = strrchr (name, '.');
-
+
+
-
-                m = g_malloc0(sizeof(*m));

trunk/libtinymail-camel/camel-lite/summary/summary.c

@@ -677 +677 @@
-        flags = fopen (flags_filename_n, "w");
-
+        if (!flags) {
+                g_free (flags_filename);
+                g_free (flags_filename_n);
+                g_list_free (items);
+                /* TODO: Error reporting */
+                g_static_rec_mutex_unlock (b->lock);
+                return;
+        }
+
-        while (items) {
-                SummaryItem *item = (SummaryItem *) items->data;

trunk/libtinymail-maemo/tny-maemo-account-store.c

@@ -154 +154 @@
-        TnyMaemoAccountStorePriv *priv = TNY_MAEMO_ACCOUNT_STORE_GET_PRIVATE (self);
-
-
-
+
+
+
+
+
-
-        if (!strcmp (ptr, "count"))

trunk/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c

@@ -391 +391 @@
-typedef struct
-{
+        GObject *instance;
+        guint handler_id;
+} SignalSlot;
+
+typedef struct
+{
-        TnyGtkFolderStoreTreeModel *self;
-        TnyAccount *account;
@@ -403 +409 @@
-        if (tny_account_is_ready (info->account))
-        {
-
+
+
+
+
+
-                        G_CALLBACK (tny_gtk_folder_store_tree_model_on_constatus_changed), info->self);
-
-
+
+
+
+
+
-                        G_CALLBACK (tny_gtk_folder_store_tree_model_on_changed), info->self);
+                g_ptr_array_add (info->self->signals, slot);
-
-                tny_gtk_folder_store_tree_model_on_constatus_changed (info->account, 
@@ -467 +481 @@
-
-                } else {
-
+
+
+
+
+
-                                G_CALLBACK (tny_gtk_folder_store_tree_model_on_constatus_changed), self);
-
+
+
+
+
+
-                                G_CALLBACK (tny_gtk_folder_store_tree_model_on_changed), self);
+                        g_ptr_array_add (self->signals, slot);
-                }
-        }
@@ -524 +547 @@
-{
-        TnyGtkFolderStoreTreeModel *me = (TnyGtkFolderStoreTreeModel*) object;
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-
-/* Experimentally removed this. With weak referencing this ain't needed ...
@@ -594 +621 @@
-        static GType types[] = { G_TYPE_STRING, G_TYPE_UINT, G_TYPE_UINT, G_TYPE_INT, G_TYPE_OBJECT };
-
+        me->signals = g_ptr_array_new ();
-        me->fol_obs = NULL;
-        me->store_obs = NULL;