Changeset 3592

Timestamp:

04/15/08 18:34:21

Author:

pvanhoof

Message:

• • • • Various bugfixes
        

Files:

• trunk/ChangeLog (modified) (1 diff)
• trunk/libtinymail-camel/camel-lite/camel/camel-tcp-stream-ssl.c (modified) (1 diff)
• trunk/libtinymail-gnome-desktop/tny-gnome-account-store.c (modified) (6 diffs)
• trunk/libtinymail-gpe/tny-gpe-account-store.c (modified) (7 diffs)
• trunk/libtinymail-maemo/tny-maemo-account-store.c (modified) (7 diffs)
• trunk/libtinymail-olpc/tny-olpc-account-store.c (modified) (7 diffs)
• trunk/libtinymailui-gtk/tny-gtk-account-list-model.c (modified) (2 diffs)
• trunk/libtinymailui-gtk/tny-gtk-attach-list-model.c (modified) (2 diffs)

trunk/ChangeLog

@@ -4 +4 @@
-        not set to NULL
-        * Moved the POP's get-msg-qasync queue to its normal interactive queue
+        * Various bugfixes
-
-2008-04-14  Philip Van Hoof <pvanhoof@gnome.org>

trunk/libtinymail-camel/camel-lite/camel/camel-tcp-stream-ssl.c

@@ -970 +970 @@
-        dir = g_build_filename (session->storage_path, ".camel_certs", NULL);
-
-
+_with_parents
-                g_warning ("Could not create cert directory '%s': %s", dir, strerror (errno));
-                g_free (dir);

trunk/libtinymail-gnome-desktop/tny-gnome-account-store.c

@@ -358 +358 @@
-        TnyGnomeAccountStorePriv *priv = TNY_GNOME_ACCOUNT_STORE_GET_PRIVATE (self);
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-                gchar *cache_dir = gconf_client_get_string (priv->client, 
-                        "/apps/tinymail/cache_dir", NULL);
@@ -394 +380 @@
-                load_accounts (self);
-
-
-
+
-                GList *copy = priv->accounts;
-
-
+
-                        TnyAccount *account = copy->data;
-
-
-
+
-                                if (TNY_IS_STORE_ACCOUNT (account))
-                                        tny_list_prepend (list, (GObject*)account);
-
-
+
-                                if (TNY_IS_TRANSPORT_ACCOUNT (account))
-                                        tny_list_prepend (list, (GObject*)account);
-                        }
-
-                        copy = g_list_next (copy);
-                }
@@ -448 +429 @@
-
-*/
-#if 0
-static void
-tny_gnome_account_store_add_account (TnyAccountStore *self, TnyAccount *account, const gchar *type)
-{
-        TnyGnomeAccountStorePriv *priv = TNY_GNOME_ACCOUNT_STORE_GET_PRIVATE (self);
-        gchar *key = NULL;
-        gint count = gconf_client_get_int (priv->client, "/apps/tinymail/accounts/count", NULL);
-
-        g_assert (TNY_IS_ACCOUNT (account));
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/hostname", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_hostname (account), NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/proto", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_proto (account), NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/type", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, type, NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/user", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_user (account), NULL);
-        g_free (key); 
-
-        count++;
-
-        gconf_client_set_int (priv->client, "/apps/tinymail/accounts/count", 
-                count, NULL);
-
-        return;
-}
-#endif
-
-
@@ -523 +467 @@
-        TnyPlatformFactory *platfact;
-
+        priv->cache_dir = NULL;
-        priv->accounts = NULL;
-        priv->client = gconf_client_get_default ();
@@ -549 +494 @@
-        kill_stored_accounts (priv);
-
-G_LIKELY (priv->cache_dir)
+priv->cache_dir
-                g_free (priv->cache_dir);
-
@@ -570 +515 @@
-{
-        TnyGnomeAccountStorePriv *priv = TNY_GNOME_ACCOUNT_STORE_GET_PRIVATE (self);
-    
-        return priv->session;
-}

trunk/libtinymail-gpe/tny-gpe-account-store.c

@@ -334 +334 @@
-                load_accounts (self);
-
-
-
+
-                GList *copy = priv->accounts;
-
-
+
-                        TnyAccount *account = copy->data;
-
-
-
+
-                                found = TNY_ACCOUNT (g_object_ref (G_OBJECT (account)));
-                                break;
-                        }
-
-                        copy = g_list_next (copy);
-                }
@@ -360 +355 @@
-        TnyGpeAccountStorePriv *priv = TNY_GPE_ACCOUNT_STORE_GET_PRIVATE (self);
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-                gchar *cache_dir = gconf_client_get_string (priv->client, 
-                        "/apps/tinymail/cache_dir", NULL);
@@ -399 +380 @@
-        {
-                GList *copy = priv->accounts;
-
-
+
-                        TnyAccount *account = copy->data;
-
-
-
+
-                                if (TNY_IS_STORE_ACCOUNT (account))
-                                        tny_list_prepend (list, (GObject*)account);
-
-
+
-                                if (TNY_IS_TRANSPORT_ACCOUNT (account))
-                                        tny_list_prepend (list, (GObject*)account);
-                        }
-
-                        copy = g_list_next (copy);
-                }
@@ -452 +428 @@
-
-*/
-
-static void
-tny_gpe_account_store_add_account (TnyAccountStore *self, TnyAccount *account, const gchar *type)
-{
-        TnyGpeAccountStorePriv *priv = TNY_GPE_ACCOUNT_STORE_GET_PRIVATE (self);
-        gchar *key = NULL;
-        gint count = gconf_client_get_int (priv->client, "/apps/tinymail/accounts/count", NULL);
-
-        g_assert (TNY_IS_ACCOUNT (account));
-
-        count++;
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/hostname", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_hostname (account), NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/proto", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_proto (account), NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/type", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, type, NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/user", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_user (account), NULL);
-        g_free (key); 
-
-        gconf_client_set_int (priv->client, "/apps/tinymail/accounts/count", 
-                count, NULL);
-
-        return;
-}
-
-
@@ -524 +464 @@
-        TnyPlatformFactory *platfact;
-
+        priv->cache_dir = NULL;
-        priv->accounts = NULL;
-        priv->client = gconf_client_get_default ();
@@ -543 +484 @@
-tny_gpe_account_store_finalize (GObject *object)
-{
-object;       
+ object;
-        TnyGpeAccountStorePriv *priv = TNY_GPE_ACCOUNT_STORE_GET_PRIVATE (self);
-
@@ -551 +492 @@
-        kill_stored_accounts (priv);
-
-G_LIKELY (priv->cache_dir)
+priv->cache_dir
-                g_free (priv->cache_dir);
-

trunk/libtinymail-maemo/tny-maemo-account-store.c

@@ -341 +341 @@
-                load_accounts (self);
-
-
-
+
-                GList *copy = priv->accounts;
-
-
+
-                        TnyAccount *account = copy->data;
-
-
-
+
-                                found = TNY_ACCOUNT (g_object_ref (G_OBJECT (account)));
-                                break;
-                        }
-
-                        copy = g_list_next (copy);
-                }
@@ -367 +362 @@
-        TnyMaemoAccountStorePriv *priv = TNY_MAEMO_ACCOUNT_STORE_GET_PRIVATE (self);
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
-                gchar *cache_dir = gconf_client_get_string (priv->client, 
-                        "/apps/tinymail/cache_dir", NULL);
@@ -406 +387 @@
-        {
-                GList *copy = priv->accounts;
-
-
+
-                        TnyAccount *account = copy->data;
-
-
-
+
-                                if (TNY_IS_STORE_ACCOUNT (account))
-                                        tny_list_prepend (list, (GObject*)account);
-
-
+
-                                if (TNY_IS_TRANSPORT_ACCOUNT (account))
-                                        tny_list_prepend (list, (GObject*)account);
-                        }
-
-                        copy = g_list_next (copy);
-                }
@@ -460 +436 @@
-*/
-
-#if 0 /* Not used. */
-static void
-tny_maemo_account_store_add_account (TnyAccountStore *self, TnyAccount *account, const gchar *type)
-{
-        TnyMaemoAccountStorePriv *priv = TNY_MAEMO_ACCOUNT_STORE_GET_PRIVATE (self);
-        gchar *key = NULL;
-        gint count = gconf_client_get_int (priv->client, "/apps/tinymail/accounts/count", NULL);
-
-        g_assert (TNY_IS_ACCOUNT (account));
-
-        count++;
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/hostname", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_hostname (account), NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/proto", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_proto (account), NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/type", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, type, NULL);
-        g_free (key); 
-
-        key = g_strdup_printf ("/apps/tinymail/accounts/%d/user", count);
-        gconf_client_set_string (priv->client, (const gchar*) key, 
-                tny_account_get_user (account), NULL);
-        g_free (key); 
-
-        gconf_client_set_int (priv->client, "/apps/tinymail/accounts/count", 
-                count, NULL);
-
-        return;
-}
-#endif
-
-
-
-static TnyDevice*
@@ -504 +441 @@
-{
-        TnyMaemoAccountStorePriv *priv = TNY_MAEMO_ACCOUNT_STORE_GET_PRIVATE (self);
-
-
+
-}
-
@@ -534 +470 @@
-        TnyPlatformFactory *platfact;
-
+        priv->cache_dir = NULL;
-        priv->accounts = NULL;
-        priv->client = gconf_client_get_default ();
@@ -562 +499 @@
-        kill_stored_accounts (priv);
-
-G_LIKELY (priv->cache_dir)
+priv->cache_dir
-                g_free (priv->cache_dir);
-

trunk/libtinymail-olpc/tny-olpc-account-store.c

@@ -67 +67 @@
-
-static gchar* 
-
-per_account_get_pass(TnyAccount *account, const gchar *prompt, gboolean *cancel)
-{
@@ -77 +76 @@
-        retval = (gchar*) tny_password_getter_get_password (pwdgetter, 
-                tny_account_get_id (account), prompt, cancel);
-G_OBJECT (pwdgetter)
+pwdgetter
-
-        return retval;
@@ -91 +90 @@
-        pwdgetter = tny_platform_factory_new_password_getter (platfact);
-        tny_password_getter_forget_password (pwdgetter, tny_account_get_id (account));
-G_OBJECT (pwdgetter)
+pwdgetter
-
-        return;
@@ -166 +165 @@
-                TnyAccount *account = NULL; gint port = 0;
-                gchar *fullfilen = g_build_filename (g_get_home_dir(), 
-
+, NULL
-                keyfile = g_key_file_new ();
-
@@ -365 +364 @@
-        TnyOlpcAccountStorePriv *priv = TNY_OLPC_ACCOUNT_STORE_GET_PRIVATE (self);
-
-G_OBJECT (priv->device)
+priv->device
-}
-
@@ -394 +393 @@
-                tny_olpc_platform_factory_get_instance ());
-
+        priv->cache_dir = NULL;
-        priv->accounts = NULL;
-        priv->device = tny_platform_factory_new_device (platfact);
@@ -411 +411 @@
-        if (priv->cache_dir)
-                g_free (priv->cache_dir);
+
+        g_object_unref (priv->device);
-
-        (*parent_class->finalize) (object);

trunk/libtinymailui-gtk/tny-gtk-account-list-model.c

@@ -214 +214 @@
-
-        if (gtk_tree_model_get_iter_first (model, &iter))
-while (gtk_tree_model_iter_next (model, &iter))
+do 
-          {
+
-                GObject *citem;
-
@@ -229 +230 @@
-                }
-                g_object_unref (citem);
-
+ while (gtk_tree_model_iter_next (model, &iter));
-
-        g_mutex_unlock (me->iterator_lock);

trunk/libtinymailui-gtk/tny-gtk-attach-list-model.c

@@ -288 +288 @@
-
-        if (gtk_tree_model_get_iter_first (model, &iter))
-while (gtk_tree_model_iter_next (model, &iter))
+do
-          {
-                GObject *citem;
@@ -303 +303 @@
-                }
-                g_object_unref (citem);
-
-
+ while (gtk_tree_model_iter_next (model, &iter));
+
-        g_mutex_unlock (me->iterator_lock);
-}