Changeset 3702

Timestamp:

06/20/08 09:10:59

Author:

jdapena

Message:

* libtinymail/tny-cached-file-stream.c:

Linked the reset implementation to the stream interface.
* libtinymail/tny-cached-file.c:
Create the files synchronously, to avoid accessing the file from other
thread if this has not been created yet.
* Changelog: removed many end-of-line whitespaces.

Files:

• trunk/ChangeLog (modified) (58 diffs)
• trunk/libtinymail/tny-cached-file-stream.c (modified) (1 diff)
• trunk/libtinymail/tny-cached-file.c (modified) (5 diffs)

trunk/ChangeLog

@@ +1 @@
+2008-06-20  Jose Dapena Paz  <jdapena@igalia.com>
+
+        * libtinymail/tny-cached-file-stream.c:
+        Linked the reset implementation to the stream interface.
+
+        * libtinymail/tny-cached-file.c:
+        Create the files synchronously, to avoid accessing the file from other
+        thread if this has not been created yet.
+
+        * Changelog: removed many end-of-line whitespaces.
+
-2008-06-18  Jose Dapena Paz  <jdapena@igalia.com>
-
@@ -38 +49 @@
-
-2008-06-05  Mark Doffman  <mark.doffman@codethink.co.uk>
-
- 
+
+
-        Update .override and .defs files to reflect changes
-        in tinymail interfaces.
@@ -56 +67 @@
-
-        * camel/providers/pop3/camel-pop3-store.c (connect_to_server):
- 
+
-
-2008-06-03  Jose Dapena Paz  <jdapena@igalia.com>
@@ -108 +119 @@
-        directory (the one on top of cur, new and tmp).
-
->>>>>>> .r3690
-2008-05-26  Philip Van Hoof <pvanhoof@gnome.org>
-
@@ -391 +401 @@
-        makes you can manage certificates using the maemo tablet certificate
-        manager.
-
+
-        * libtinymail-camel/camel-lite/camel/camel-certdb.h,
-        libtinymail-camel/camel-lite/camel/camel-private.h: modified to
-        have a pointer to the CST object in certdb and certificate id in
-        certificate object in case we compile with CST support.
-
+
-        * libtinymail-camel/camel-lite/camel/camel-tcp-stream-ssl.c:
-        Modified a bit the code for proper integration with cst (mainly
-        removing direct access to internal fields).
-
+
-        * libtinymail-camel/camel-lite/configure.ac,
-        libtinymail-camel/camel-lite/camel/Makefile.am:
@@ -789 +799 @@
-        libtinymail-camel/camel-lite/camel/camel-store-summary.c:
-        Added the proper error codes when there is no enough space left on
-        
+
-
-2008-01-29  Philip Van Hoof <pvanhoof@gnome.org>
@@ -810 +820 @@
-2008-01-27  Philip Van Hoof <pvanhoof@gnome.org>
-
- 
+
-        * Merged camel-lite with upstream camel revision 8428
-
@@ -871 +881 @@
-
-2008-01-21 Dirk-Jan C. Binnema <dirk-jan.binnema@nokia.com>
-
+
-        * fix freeing uninitialized data in camel-imap-folder.c
-
@@ -930 +940 @@
-
-        * fix for use of unitialized variable in decode_it function,
- 
+
-
-2008-01-15  Sergio Villar Senin  <svillar@igalia.com>
@@ -968 +978 @@
-
-        * Merged camel-lite with Camel upstream rev. 8360
- 
+
-        crash once
-        * Size determining when adding items to a local maildir folder
@@ -987 +997 @@
-
-2008-01-10 Dirk-Jan C. Binnema <dirk-jan.binnema@nokia.com>
-
+
-        * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store-summary:
-        fix typo in camel-imap-store-summary.c which caused valgrind errors
@@ -998 +1008 @@
-
-2008-01-09  Dirk-Jan C. Binnema <dirk-jan.binnema@nokia.com>
-
+
-        * small fixes / cleanups for tny-maemo-conic-device
-
@@ -1069 +1079 @@
-
-        * libtinymail-camel/camel-lite/camel/providers/imap/camel-
- 
+
-        value to variable len
-        * libtinymail/tny-store-acount.c:
@@ -1151 +1161 @@
-
-        * libtinymail-camel/tny-camel-mime-part.c
- 
+
-
-2007-12-13  Felipe Erias Morandeira  <femorandeira@igalia.com>
@@ -1179 +1189 @@
-        can be added with g_object_ref or a weak reference.
-        * libtinymail-camel/tny-camel-folder.c: now the TnyCamelHeader we
- 
+
-        This is created in a way it's persistent, and then, we can access
-        properly to the summary flags. We also eturn null and set error if
@@ -1205 +1215 @@
-
-        * libtinymail-camel/tny-camel-folder.c:
-    
+
-        * libtinymail/tny-folder.[ch]
-        libtinymail/tny-shared.h
@@ -1215 +1225 @@
-2007-12-09  Dirk-Jan C. Binnema <djcb@djcbsoftware.nl>
-
- 
+
-
-2007-12-08  Jürg Billeter  <j@bitron.ch>
@@ -1268 +1278 @@
-
-        * Merge from devel/pvanhoof/bs branch
-
+
-2007-11-30  Philip Van Hoof  <pvanhoof@gnome.org>
-
@@ -1299 +1309 @@
-
-2007-11-26 Dirk-Jan C. Binnema <djcb@djcbsoftware.nl>
-
+
-        * add a dummy conic device, so libtinymail-maemo does
-          not require libconic anymore
@@ -1471 +1481 @@
-2007-11-09  Sergio Villar Senin  <svillar@igalia.com>
-
- 
+
-        Added a new API to allow asynchronous connections
-        in the Maemo conic device. This patch is a new version of an initial
@@ -1477 +1487 @@
-        Splitted the Maemo connic device in two files, one for the actual
-        device and the other one for a dummy device (useful for sbox devel)
- 
-
+
+
-2007-11-08  Jose Dapena Paz  <jdapena@igalia.com>
-
@@ -1533 +1543 @@
-
-2007-11-05  Dirk-Jan C. Binnema <dirk-jan.binnema@nokia.com>
-
+
-        * Don't leak an fp in md5_get_digest_from_file
-
@@ -1546 +1556 @@
-
-        * Bugfix when renaming or moving a local folder. Not all of its sub-
- 
+
-        camel_store_get_folder_info returned an iter with only one child in it.
-        Either it should return no childs or all childs. I adapted Tinymail to
@@ -1585 +1595 @@
-        * Using the SSL negotiated timeout time for IDLE's recycle (undone)
-        * Undone last timeout change, set it to 27 minutes fixed for IMAP
-
+
-2007-10-29  Jose Dapena Paz  <jdapena@igalia.com>
-
@@ -1750 +1760 @@
-        id with the merged folder id's and their account
-        id's.
- 
+
-        implementation. Now it gets the merge folder id
-        as part of the url string with this format:
@@ -1778 +1788 @@
-
-2007-09-25  Mark Doffman <mark.doffman@codethink.co.uk>
-
+
-        * /bindings/python/*: Remove the platform generation
- 
+
-
-        * /bindings/python/README: Update for changes to the way
-        the python bindings are generated.
-
+
-        * /tests/python-demo/*: Add implementations of a tny-list
- 
- 
+
+
-
-        * /tests/python-demo/tinymail-python-test.py: Modify to use
-        the python implementation of the platform factory.
-
+
-2007-09-24  Philip Van Hoof  <pvanhoof@gnome.org>
-
@@ -1812 +1822 @@
-        to the tinymail library.
-
- 
+
-        the CLEANFILES to fix release problems.
-
@@ -1842 +1852 @@
-
-        * /bindings/python/gendefs/defsgen.py:
- 
+
-        generated.
-
@@ -1851 +1861 @@
-        * /bindings/python/*.defs: Include virtual method
-        definitions. All Tinymail and Tinymailui interfaces
- 
+
-
-        * /bindings/python/*.override: I add type definitions
-    
+
-        updated .defs files.
-
@@ -1864 +1874 @@
-        * Disconnecting the old settings if new settings are set and
-        tny_camel_account_set_online is issued (experimental)
- 
+
-
-2007-09-13  Jose Dapena Paz  <jdapena@igalia.com>
-
- 
- 
+
+
-        we've got empty strings as valid imap folders).
-
-        * libtinymail-camel/tny-camel-msg-header-priv.h: Add internal API
-        to set a decorated header (at least for updating flag values).
-
- 
- 
+
+
+
-        we'll set/unset/get also the decorated header.
-
+
-        * libtinymail-camel/tny-camel-partial-msg-receive-strategy.c: Now
- 
- 
+
+
-        header obtained from the message.
-
- 
+
+
-        set the folder header as decorated by the msg header.
-
@@ -1950 +1960 @@
-2007-09-04  Murray Cumming  <murrayc@murrayc.com>
-
- 
+
-        TnyCamelGetSupportedSecureAuthCallback callback to provide a
-        GError* instead of a GError**, because it is not an output parameter.
@@ -1979 +1989 @@
-        (tny_camel_account_set_port_default),
-        (tny_camel_account_set_pass_func_default),
- 
- 
+
+
-        the account has changed.
-
-2007-09-04  Javier Fernandez Garcia-Boente  <jfernandez@igalia.com>
-
- 
+
-        the new change object to propagate it to observers.
-
+
-2007-09-04  Sergio Villar Senin  <svillar@igalia.com>
-
@@ -1998 +2008 @@
-        libtinymail-camel/camel-lite/configure.ac : fixes a maemo integration
-        build error.
-
+
-2007-09-04  Philip Van Hoof  <pvanhoof@gnome.org>
-
@@ -2017 +2027 @@
-        really recognizable anymore so it shouldn't copy the copyright of the
-        original as this is not a copy anymore.
- 
+
-        * Fixed filedescriptor leaks with local folders
-        * Fixed online command attempts when password got cancelled
@@ -2029 +2039 @@
-
-        * Add a new API function, tny_send_queue_add_async to define
- 
- 
+
+
-
-2007-09-03  Sergio Villar Senin  <svillar@igalia.com>
@@ -2048 +2058 @@
-
-2007-08-31 Dirk-Jan C. Binnema <dirk-jan.binnema@nokia.com>
-
+
-        * Fix tny_camel_msg_header_date_(sent|received):
-                - don't try to normalize to GMT (camel already does that)
@@ -2062 +2072 @@
-2007-08-28  Javier Fernandez Garcia-Boente  <jfernandez@igalia.com>
-
- 
- 
- 
- 
+
+
+
+
-
-2007-08-15  Philip Van Hoof  <pvanhoof@gnome.org>
@@ -2075 +2085 @@
-
-        * libtinymail-maemo/tny-maemo-conic-device.c:
- 
+
-        about an unused variable.
-
@@ -2094 +2104 @@
-
-        * libtinymail-maemo/tny-maemo-conic-device.c:
- 
+
-        to TRUE.
-        * This is a hack that fixes a problem
- 
- 
+
+
-        * detect when the mainloop has not yet started.
-        * The downside is that we now don't know that we are really offline,
@@ -2107 +2117 @@
-
-        * libtinymail-maemo/tny-maemo-conic-device.c: (conic_emit_status):
- 
+
-        way to do this, and it causes hangs if we never use the idle handler.
-        See the comments in the code.
@@ -2119 +2129 @@
-        * libtinymail-maemo/tny-maemo-conic-device.c:
-        (conic_emit_status_idle), (conic_emit_status):
- 
- 
- 
+
+
+
-        See the comments to see why this is OK for tinymail.
-
@@ -2128 +2138 @@
-        * libtinymail-maemo/tny-maemo-conic-device.c:
-        (on_connection_event), (tny_maemo_conic_device_get_iap):
- 
+
-
-2007-08-14  Murray Cumming  <murrayc@murrayc.com>
-
-        * libtinymail-maemo/tny-maemo-conic-device.c:
- 
+
-        forcing the on_connection_event() signal handler to be called, not after,
- 
+
-        when it should not be.
-
@@ -2141 +2151 @@
-
-        * libtinymail-camel/tny-camel-folder.c:
- 
+
-        to fix a compiler warning.
- 
+
-        changes requested by Philip.
-
@@ -2194 +2204 @@
-        * tests/c-demo/tny-demoui-summary-view.c:
-        (on_header_view_tree_row_activated):
- 
- 
+
+
-        again.
-
@@ -2260 +2270 @@
-        sync operation's reconnect)
-        * Added the changed signal to TnyAccount
- 
+
-        TreeModel instance.
-        * Fixed a kludge in the TnySessionCamel for POP accounts with wrong
@@ -2290 +2300 @@
-
-        * Fixed some bugs in TnyMergeFolder notification function. This
- 
+
-        new_change structure to propagate changes to observed folders.
-
@@ -2299 +2309 @@
-
-        * camel/camel-mime-parser.c: (folder_scan_content),
- 
- 
+
+
-        fix it but it should make things clearer for someone who can fix it.
-
@@ -2345 +2355 @@
-        * Cond locks in the queues of the store accounts while the callbacks
-        are happening. This is a significant policy change in locking
- 
+
-
-        * This was a major API change in TnyAccount
@@ -2376 +2386 @@
-2007-07-23  Murray Cumming  <murrayc@murrayc.com>
-
- 
+
-        documentation for tny_camel_account_set_online().
-
-        * libtinymail/tny-merge-folder.c: (tny_merge_folder_get_id),
- 
- 
- 
+
+
+
-        contract, causing a crash at runtime when DBC is enabled in the build.
-
@@ -2392 +2402 @@
-
-2007-07-23  Jose Dapena Paz  <jdapena@igalia.com>
-
+
-        * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
-        (imap_refresh_info): now we lock the folder also, before locking the
-        service, in order to respect better the lock order. This should avoid
-        some locks.
-
+
-        * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.[ch]:
-        now we store a reference to the struct addrinfo used for connections. When
@@ -2406 +2416 @@
-        flooding the connection.
-        We also removed the method (camel_imap_service_connect) as it's not used.
-
+
-        * libtinymail-camel/camel-lite/camel/camel-private.h:
-        added parenthesis to some lock macros.
-
+
-2007-07-23  Jose Dapena Paz  <jdapena@igalia.com>
-
@@ -2415 +2425 @@
-        with a reason. This prevents some interlock problems, as the
-        last unreason can lead to a folder lock.
-
+
-2007-07-23  Jose Dapena Paz  <jdapena@igalia.com>
-
@@ -2423 +2433 @@
-        object when the attachment is a message.
-        (tny_camel_mime_part_add_part_default): now when we are
- 
+
-        message/rfc822 mime part that contains the message as
-        its content object. This fixes attaching messages.
@@ -2450 +2460 @@
-
-        * libtinymail-camel/tny-camel-account.c:
- 
- 
+
+
-        considering all maildir accounts to be the same account.
-
@@ -2467 +2477 @@
-2007-07-09  Javier Fernández García-Boente <jfernandez@igalia.com>
-        * Implements and emits msg-sending and msg-sent signals
- 
- 
+
+
-        tny_camel_folder_remove_msg_default method.
-
@@ -2499 +2509 @@
-        (tny_olpc_account_store_alert):
-        * tests/shared/account-store.c: (tny_test_account_store_alert):
- 
- 
- 
+
+
+
-        implementations (see the *ssl.c comment below).
-
@@ -2507 +2517 @@
-        * camel/camel-session.c: (camel_session_alert_user),
-        (camel_session_alert_user_with_id),
- 
- 
- 
+
+
+
-        * camel/camel-disco-diary.c: (camel_disco_diary_log),
-        (diary_decode_folder):
@@ -2521 +2531 @@
-        Pass the CamelService::data to camel_session_alert_user*().
-        * camel/camel-tcp-stream-openssl.c: (ssl_verify):
- 
- 
+
+
-        See the TODOs.
-

trunk/libtinymail/tny-cached-file-stream.c

@@ -212 +212 @@
-        klass->write= tny_cached_file_stream_write;
-        klass->close= tny_cached_file_stream_close;
+        klass->reset= tny_cached_file_stream_reset;
-
-        return;

trunk/libtinymail/tny-cached-file.c

@@ -191 +191 @@
-        flags = O_RDWR;
-        if (creation) {
-
+ | O_SYNC
-        } else {
-                flags |= O_RDONLY;
@@ -292 +292 @@
-typedef struct {
-        TnyCachedFile *self;
-TnyStream *write_stream
+gint write_fd
-} AsyncFetchStreamData;
-
@@ -302 +302 @@
-        TnyCachedFilePriv *priv;
-        TnyStream *write_stream;
-        int write_fd;
-
-        self = afs_data->self;
@@ -308 +307 @@
-
-        /* First we dump the read stream contents to file cache */
-
-
-
+
-        while (!tny_stream_is_eos (priv->fetch_stream)) {
-                gssize readed, written;
@@ -428 +425 @@
-                afs_data = g_slice_new0 (AsyncFetchStreamData);
-                afs_data->self = g_object_ref (result);
+                afs_data->write_fd = get_new_fd_of_stream (result, TRUE, TRUE);
+                lseek (afs_data->write_fd, 0, SEEK_SET);
-                g_thread_create (async_fetch_stream, afs_data, FALSE, NULL);
-        } else {