Changeset 3705

Timestamp:

06/25/08 10:33:36

Author:

jdapena

Message:

* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c:

• • • • Don't set in_idle to false so that join works properly.
        
      • On disconnecting we forze a stop_idle so we warrant idle
        thread has died when we disconnect.
        
      • Send let idle die commands on disconnecting.
        
      • It's very important to make the idle thread die on time as it
        keeps a reference to the folder. Folder keeps a reference to
        this store, and then store should finish idle soon to be able
        to finalize (cycle reference).
        

* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:

• • • • On finishing the idle thread we state we're out of it.
        

* libtinymail-camel/camel-lite/camel.c:

• • • • Avoid running internal methods of camel_shutdown two times if
        we can call shutdown two times.
        

* libtinymail-camel/tny-session-camel.c:

• • • • Keep a proper reference to TnyDevice.
        

* libtinymail-camel/tny-camel-store-account.c:

• • • • Free the iter store reference on finalising.
        

* libtinymail-camel/tny-camel-account.c:

• • • • Set service to null after unreffing it.
        

* libtinymailui-gtk/tny-gtk-folder-store-tree-model.c:

• • • • Don't get folders again when we change status to disconnected.
        

Files:

• trunk/libtinymail-camel/camel-lite/camel/camel.c (modified) (2 diffs)
• trunk/libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c (modified) (1 diff)
• trunk/libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c (modified) (4 diffs)
• trunk/libtinymail-camel/tny-camel-account.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-camel-store-account.c (modified) (1 diff)
• trunk/libtinymail-camel/tny-session-camel.c (modified) (2 diffs)
• trunk/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c (modified) (1 diff)

trunk/libtinymail-camel/camel-lite/camel/camel.c

@@ -55 +55 @@
-                return;
-
+        initialised = FALSE;
-        certdb = camel_certdb_get_default ();
-        if (certdb) {
@@ -66 +67 @@
-#endif /* HAVE_NSS */
-
-        initialised = FALSE;
-}
-

trunk/libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c

@@ -4221 +4221 @@
-        }
-
+        store->in_idle = FALSE;
-        camel_object_unref (folder);
-

trunk/libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c

@@ -235 +235 @@
-                CAMEL_SERVICE_REC_LOCK (store, connect_lock);
-                nwritten = camel_stream_printf (store->ostream, "DONE\r\n");
-                store->in_idle = FALSE;
-                if (nwritten != -1) {
-                        resp = NULL;
@@ -397 +396 @@
-
-        let_idle_die (imap_store, TRUE);
+
+        camel_imap_store_stop_idle (imap_store);
-
-        if (imap_store->current_folder) {
@@ -2101 +2102 @@
-        imap_debug ("imap_connect_offline\n");
-
-
+
+
-
-        if (!disco_store->diary)
@@ -2118 +2120 @@
-        imap_debug ("imap_disconnect_offline\n");
-
-
+
+
-
-        if (store->istream) {

trunk/libtinymail-camel/tny-camel-account.c

@@ -2163 +2163 @@
-                }
-                camel_object_unref (CAMEL_OBJECT (priv->service));
+                priv->service = NULL;
-        }
-

trunk/libtinymail-camel/tny-camel-store-account.c

@@ -1412 +1412 @@
-        priv->iter = iter;
-        priv->cant_reuse_iter = FALSE;
+
+        if (priv->iter_store) {
+                camel_object_unref (CAMEL_OBJECT (store));
+        }
-
-        camel_object_ref (CAMEL_OBJECT (store));

trunk/libtinymail-camel/tny-session-camel.c

@@ -983 +983 @@
-         * have embraced references either. So be careful! */
-
-device
+g_object_ref (device)
-
-        return;
@@ -1090 +1090 @@
-                g_signal_handler_disconnect (G_OBJECT (priv->device), 
-                        priv->connchanged_signal);
+        }
+
+        if (priv->device) {
+                g_object_unref (priv->device);
-        }
-

trunk/libtinymailui-gtk/tny-gtk-folder-store-tree-model.c

@@ -339 +339 @@
-         * start asking the account about its folders. */
-
-
+ || status == TNY_CONNECTION_STATUS_DISCONNECTED
-                return;
-