Ticket #8 (enhancement)
Opened 2 years ago
Last modified 1 year ago
Certificate/error handling doesn't specify the account
Status: closed (fixed)
| Reported by: | pvanhoof | Assigned to: | pvanhoof |
|---|---|---|---|
| Priority: | major | Milestone: | A second release |
| Component: | libtinymail-camel | Version: | 2.0 |
| Keywords: | Cc: | ||
This could be improved by modifying camel-lite's API:
Attachments
Change History
07/10/07 11:07:25: Modified by anonymous
- summary changed from Certificate handling is unlinked with the account at this moment to Certificate/error handling doesn't specify the account.
07/10/07 11:11:25: Modified by murrayc@murrayc.com
- attachment tny_alert_func.patch added.
tny_alert_func.patch
07/10/07 11:13:23: Modified by murrayc@murrayc.com
tny_alert_func.patch is a half-done patch that tried to add the parameter, before I realized that CamelSession? has no way to provide information about the account. See the obvious TODO comment in the patch.
07/10/07 11:25:43: Modified by murrayc@murrayc.com
Philip said on irc:
<pvanhoof> murrayc, oh the alert things: there's indeed only want way to fix it <pvanhoof> and that's to go after each and every invoke of ->alert ()
And add the parameter Each and everyone will have the CamelService?, which is per account the service also has a ->data pointer, which I added to camel :-\ it's filled in with the pointer to the TnyAccount <murrayc> OK. I'll take another look. <sergio> djcb: I'll check <pvanhoof> murrayc, so if you can add the CamelService's instance to the function, at each location where it's called <pvanhoof> then you have a fix More or less like how the get_pass and forget_pass are used
07/10/07 12:28:27: Modified by murrayc@murrayc.com
- attachment tny_alert_func_working.patch added.
This one works. Permission to apply?
07/10/07 18:40:46: Modified by anonymous
- status changed from new to closed.
- resolution set to fixed.
The TnyAccountStore::alert_func() vfunc does not provide a TnyAccount* parameter, so there's no way to show the user what account failed, or ,for instance, what server hostname could not be reached. We can't even know whether it was a POP or IMAP failure.
Murray (Who can't login because Trace is broken. Who wishes you used the GNOME infrastructure.)